Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1065: Publish ClusterRoles for csi driver sidecars #379

Commits on Jun 23, 2023

  1. STOR-1065: Publish ClusterRoles for csi driver sidecars

    The PR adds a bunch of new ClusterRoles to `manifests/ dir. This way those new ClusterRoles will be always created, regardless of cloud. They are building blocks to compose ClusterRoles for CSI dirver sidecars. For example, `external-provisioner` sidecar for `aws-ebs` csi driver can compose the same ClusterRole as in https://github.com/openshift/aws-ebs-csi-driver-operator/blob/master/assets/rbac/provisioner_role.yaml by adding ClusterRoleBindings for `openshift-csi-main-provisioner-role` and `openshift-csi-provisioner-volumesnapshot-reader-role`. The only exception is `leases` rules which need to be moved from ClusterRoles to per-namespace Roles anyway.
    
    As soon as this change is merged into `cluster-storage-operator`, it will be possible to get rid of ClusterRole definitions in csi driver operators, they will only define ClusterRoleBindings referring these new ClusterRoles.
    mpatlasov committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f494707 View commit details
    Browse the repository at this point in the history