Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15940: Revert revert of hypershift cleanup #385

Merged
merged 2 commits into from Jul 13, 2023
Merged

OCPBUGS-15940: Revert revert of hypershift cleanup #385

merged 2 commits into from Jul 13, 2023

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jul 7, 2023

Fixes OCPBUGS-15940

@gnufied
Revert "Merge pull request openshift#384 from xueqzhan/revert-381-sta…
2b8e4fc 
…rt-hypershift-refactor"

This reverts commit 1611e65, reversing
changes made to 972c4d8.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 7, 2023
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Jira Issue OCPBUGS-15940, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes OCPBUGS-15940

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bertinatto and dobsonj July 7, 2023 20:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@gnufied gnufied force-pushed the revert-hypershift-cleanup branch from 35bb66d to fa9af3a Compare July 7, 2023 20:49
@gnufied
Copy link
Member Author

gnufied commented Jul 8, 2023

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-sdn-bm
/test e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2023

@gnufied: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2e482110-1d8c-11ee-92d6-1b75d2adbb50-0

@gnufied
Copy link
Member Author

gnufied commented Jul 11, 2023

/retest

bertinatto
bertinatto reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@gnufied
Copy link
Member Author

gnufied commented Jul 11, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 11, 2023
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Jira Issue OCPBUGS-15940, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1611e65 and 2 for PR HEAD fa9af3a in total

@gnufied
Copy link
Member Author

gnufied commented Jul 12, 2023

/retest

@gnufied
Copy link
Member Author

gnufied commented Jul 12, 2023

/retest-required

@gnufied
Copy link
Member Author

gnufied commented Jul 13, 2023

/retest

@jsafrane
Copy link
Contributor

/test e2e-gcp-ovn

1 similar comment
@gnufied
Copy link
Member Author

gnufied commented Jul 13, 2023

/test e2e-gcp-ovn

@openshift-merge-robot openshift-merge-robot merged commit b5cfc04 into openshift:master Jul 13, 2023
14 checks passed
@openshift-ci-robot
Copy link
Contributor

@gnufied: Jira Issue OCPBUGS-15940: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15940 has been moved to the MODIFIED state.

In response to this:

Fixes OCPBUGS-15940

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@dobsonj dobsonj Awaiting requested review from dobsonj

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gnufied @openshift-ci-robot @jsafrane @bertinatto @openshift-merge-robot