Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16265: Publish csi sidecar clusterroles earlier #386

Merged
merged 1 commit into from Jul 19, 2023
Merged

OCPBUGS-16265: Publish csi sidecar clusterroles earlier #386

merged 1 commit into from Jul 19, 2023

Conversation

mpatlasov
Copy link
Contributor

@mpatlasov mpatlasov commented Jul 13, 2023 •
edited

Without numeric prefix clustrroles are published very late, sometimes ~14 mins after csi driver oprator is started. This leads to installation failures like this:

ERROR Cluster operator storage Degraded is True with IBMVPCBlockCSIDriverOperatorCR_IBMBlockDriverStaticResourcesController_SyncError: IBMVPCBlockCSIDriverOperatorCRDegraded: IBMBlockDriverStaticResourcesControllerDegraded: "rbac/main_attacher_binding.yaml" (string): clusterroles.rbac.authorization.k8s.io "openshift-csi-main-attacher-role" not found

This PR makes csi clusterroles to be published before csi driver operator started. See openshift/ibm-vpc-block-csi-driver-operator#64 (comment) for verification.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2023
@mpatlasov
Copy link
Contributor Author

/retest

@mpatlasov mpatlasov force-pushed the WIP-publish-csi-sidecars-earlier branch 2 times, most recently from 7cf45ec to a6e7f58 Compare July 18, 2023 05:45
@mpatlasov
Copy link
Contributor Author

/test e2e-ibmcloud-csi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@mpatlasov: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upgrade
  • /test e2e-gcp-ovn
  • /test hypershift-aws-e2e-external
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws-csi
  • /test e2e-aws-shared-resources
  • /test e2e-azure-csi
  • /test e2e-azure-file-csi
  • /test e2e-azure-ovn
  • /test e2e-gcp-csi
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-ovn-vsphere
  • /test e2e-vsphere-csi

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-storage-operator-master-e2e-aws-ovn
  • pull-ci-openshift-cluster-storage-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-storage-operator-master-e2e-azure-csi
  • pull-ci-openshift-cluster-storage-operator-master-e2e-azure-file-csi
  • pull-ci-openshift-cluster-storage-operator-master-e2e-azure-ovn
  • pull-ci-openshift-cluster-storage-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-cluster-storage-operator-master-e2e-ovn-vsphere
  • pull-ci-openshift-cluster-storage-operator-master-e2e-vsphere-csi
  • pull-ci-openshift-cluster-storage-operator-master-hypershift-aws-e2e-external
  • pull-ci-openshift-cluster-storage-operator-master-images
  • pull-ci-openshift-cluster-storage-operator-master-unit
  • pull-ci-openshift-cluster-storage-operator-master-verify
  • pull-ci-openshift-cluster-storage-operator-master-verify-deps

In response to this:

/test e2e-ibmcloud-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov
STOR-1065: Publish csi sidecar clusterroles earlier
c4faf55 
Without numeric prefix clustrroles are published very late, sometimes ~14 mins after csi driver oprator is started. This leads to installation failures like this:
```
ERROR Cluster operator storage Degraded is True with IBMVPCBlockCSIDriverOperatorCR_IBMBlockDriverStaticResourcesController_SyncError: IBMVPCBlockCSIDriverOperatorCRDegraded: IBMBlockDriverStaticResourcesControllerDegraded: "rbac/main_attacher_binding.yaml" (string): clusterroles.rbac.authorization.k8s.io "openshift-csi-main-attacher-role" not found
```
@mpatlasov mpatlasov force-pushed the WIP-publish-csi-sidecars-earlier branch from a6e7f58 to c4faf55 Compare July 18, 2023 17:38
@mpatlasov
Copy link
Contributor Author

Tested that 17_ prefix is still published too late:

$ oc get clusterrole vpc-block-provisioner-role
NAME                         CREATED AT
vpc-block-provisioner-role   2023-07-18T10:53:01Z

$ oc get clusterrole openshift-csi-main-provisioner-role
NAME                                  CREATED AT
openshift-csi-main-provisioner-role   2023-07-18T11:08:19Z

(+ 15 mins since ibm-vpc csi driver operator started)

Let's switch back to 09_.

@mpatlasov
Copy link
Contributor Author

/test e2e-vsphere-csi

@mpatlasov mpatlasov mentioned this pull request Jul 18, 2023
Merged
@mpatlasov
Copy link
Contributor Author

/test hypershift-aws-e2e-external

@mpatlasov mpatlasov changed the title WIP: Publish csi sidecar clusterroles earlier OCPBUGS-16265: Publish csi sidecar clusterroles earlier Jul 18, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 18, 2023
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: This pull request references Jira Issue OCPBUGS-16265, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Without numeric prefix clustrroles are published very late, sometimes ~14 mins after csi driver oprator is started. This leads to installation failures like this:

ERROR Cluster operator storage Degraded is True with IBMVPCBlockCSIDriverOperatorCR_IBMBlockDriverStaticResourcesController_SyncError: IBMVPCBlockCSIDriverOperatorCRDegraded: IBMBlockDriverStaticResourcesControllerDegraded: "rbac/main_attacher_binding.yaml" (string): clusterroles.rbac.authorization.k8s.io "openshift-csi-main-attacher-role" not found

This PR makes csi clusterroles to be published before csi driver operator started. See openshift/ibm-vpc-block-csi-driver-operator#64 (comment) for verification.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 18, 2023
@mpatlasov
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mpatlasov: This pull request references Jira Issue OCPBUGS-16265, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov
Copy link
Contributor Author

/test hypershift-aws-e2e-external

@mpatlasov
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 18, 2023
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: This pull request references Jira Issue OCPBUGS-16265, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhou@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov
Copy link
Contributor Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6d96ffe into openshift:master Jul 19, 2023
14 checks passed
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: Jira Issue OCPBUGS-16265: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16265 has been moved to the MODIFIED state.

In response to this:

Without numeric prefix clustrroles are published very late, sometimes ~14 mins after csi driver oprator is started. This leads to installation failures like this:

ERROR Cluster operator storage Degraded is True with IBMVPCBlockCSIDriverOperatorCR_IBMBlockDriverStaticResourcesController_SyncError: IBMVPCBlockCSIDriverOperatorCRDegraded: IBMBlockDriverStaticResourcesControllerDegraded: "rbac/main_attacher_binding.yaml" (string): clusterroles.rbac.authorization.k8s.io "openshift-csi-main-attacher-role" not found

This PR makes csi clusterroles to be published before csi driver operator started. See openshift/ibm-vpc-block-csi-driver-operator#64 (comment) for verification.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov mpatlasov mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@dobsonj dobsonj Awaiting requested review from dobsonj

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mpatlasov @openshift-ci-robot @jsafrane @openshift-merge-robot