Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "get" verb from "events" resource of RBAC for provisioner sidecar #390

Conversation

mpatlasov
Copy link
Contributor

Let's keep manifests/09_sidecar-main_provisioner_role.yaml in sync with upstream (https://github.com/openshift/csi-external-provisioner/blob/master/deploy/kubernetes/rbac.yaml)

See discussion at openshift/aws-ebs-csi-driver-operator#245.

@mpatlasov
Copy link
Contributor Author

/assign @jsafrane

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@mpatlasov
Copy link
Contributor Author

mpatlasov commented Aug 1, 2023

@gnufied , I remember you wrote in openshift/aws-ebs-csi-driver-operator#245:

I think it is unnecessary to remove get permissions when - list, watch etc is included. I would think that, there might be code that assumes it has get permissions because it has list permissions etc. It would surprise such users.

It also doesn't buys much in terms of reducing permission vector of the sidecar/operators.

and after that Jan wrote there recently:

I think we should use upstream RBAC definitions where possible. If we're going to use custom permissions, then we need to review all code an updated driver to see if we need to modify them. If we use the upstream ones, then it's task of the upstream to keep them up to date and we can blindly copy them.

Feel free to comment/reject here if you believe we have to avoid such changes...

@mpatlasov
Copy link
Contributor Author

/test hypershift-aws-e2e-external
/test e2e-vsphere-csi
/test e2e-ovn-vsphere

@mpatlasov
Copy link
Contributor Author

/test e2e-ovn-vsphere

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

jsafrane commented Aug 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@mpatlasov
Copy link
Contributor Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 3, 2023
@Phaow
Copy link

Phaow commented Aug 3, 2023

/label qe-approved
CI looks good enough for the minor change.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1a74213 into openshift:master Aug 4, 2023
14 checks passed
@jsafrane
Copy link
Contributor

/test help
just using this PR to check CI jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants