New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "get" verb from "events" resource of RBAC for provisioner sidecar #390
Remove "get" verb from "events" resource of RBAC for provisioner sidecar #390
Conversation
Let's keep `manifests/09_sidecar-main_provisioner_role.yaml` in sync with upstream (https://github.com/openshift/csi-external-provisioner/blob/master/deploy/kubernetes/rbac.yaml) See discussion at openshift/aws-ebs-csi-driver-operator#245.
/assign @jsafrane |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gnufied , I remember you wrote in openshift/aws-ebs-csi-driver-operator#245:
and after that Jan wrote there recently:
Feel free to comment/reject here if you believe we have to avoid such changes... |
/test hypershift-aws-e2e-external |
/test e2e-ovn-vsphere |
@mpatlasov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/label docs-approved |
/label qe-approved |
/test help |
Let's keep
manifests/09_sidecar-main_provisioner_role.yaml
in sync with upstream (https://github.com/openshift/csi-external-provisioner/blob/master/deploy/kubernetes/rbac.yaml)See discussion at openshift/aws-ebs-csi-driver-operator#245.