Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1432: hypershift: pass through control plane images to AWS EBS CSI driver operator #393

Merged
merged 1 commit into from Aug 9, 2023
Merged

STOR-1432: hypershift: pass through control plane images to AWS EBS CSI driver operator #393

merged 1 commit into from Aug 9, 2023

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Aug 8, 2023 •
edited

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2023
@sjenning sjenning changed the title WIP: hypershift: pass through control plane images to AWS EBS CSI driver operator WIP: STOR-1432: hypershift: pass through control plane images to AWS EBS CSI driver operator Aug 8, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 8, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 8, 2023 •
edited by openshift-ci bot

@sjenning: This pull request references STOR-1432 which is a valid jira issue.

In response to this:

continuing work of

with a follow on in https://github.com/openshift/aws-ebs-csi-driver-operator coming soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

sjenning commented Aug 8, 2023

cc @jsafrane @gnufied @bertinatto

@sjenning sjenning changed the title WIP: STOR-1432: hypershift: pass through control plane images to AWS EBS CSI driver operator STOR-1432: hypershift: pass through control plane images to AWS EBS CSI driver operator Aug 8, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2023
@sjenning sjenning mentioned this pull request Aug 8, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 8, 2023 •
edited by openshift-ci bot

@sjenning: This pull request references STOR-1432 which is a valid jira issue.

In response to this:

continuing work of

with a follow on in https://github.com/openshift/aws-ebs-csi-driver-operator

openshift/aws-ebs-csi-driver-operator#252

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

sjenning commented Aug 8, 2023

/retest-required

@sjenning sjenning force-pushed the control-plane-image-awareness branch from 3fba51a to 22b559a Compare August 9, 2023 01:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented Aug 9, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@gnufied
Copy link
Member

gnufied commented Aug 9, 2023

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 9, 2023
@radeore
Copy link

radeore commented Aug 9, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit e5e74e9 into openshift:master Aug 9, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@dobsonj dobsonj Awaiting requested review from dobsonj

@mpatlasov mpatlasov Awaiting requested review from mpatlasov

Assignees

@gnufied gnufied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjenning @openshift-ci-robot @gnufied @radeore @openshift-merge-robot