Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19073: Move KAS access label to right place #403

Merged
merged 1 commit into from Oct 9, 2023
Merged

OCPBUGS-19073: Move KAS access label to right place #403

merged 1 commit into from Oct 9, 2023

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Oct 2, 2023

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 2, 2023
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Jira Issue OCPBUGS-19073, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ropatil010

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes https://issues.redhat.com/browse/OCPBUGS-19073

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Jira Issue OCPBUGS-19073, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ropatil010

In response to this:

Fixes https://issues.redhat.com/browse/OCPBUGS-19073

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
@ropatil010
Copy link

/retest

@openshift-merge-robot
Copy link
Contributor

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-aws-e2e-external 4fb66af link true /test hypershift-aws-e2e-external
ci/prow/e2e-ibmcloud-csi 4fb66af link false /test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jsafrane
jsafrane reviewed Oct 3, 2023
View reviewed changes
assets/csidriveroperators/aws-ebs/hypershift/mgmt/deployment.patch.yaml Outdated
spec:
template:
metadata:
labels:
hypershift.openshift.io/need-management-kas-access: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing quotes around true.

E1002 22:02:46.995956 1 runtime.go:79] Observed a panic: &json.UnmarshalTypeError{Value:"bool", Type:(*reflect.rtype)(0x254b2c0), Offset:437, Struct:"ObjectMeta", Field:"spec.template.metadata.labels"} (json: cannot unmarshal bool into Go struct field ObjectMeta.spec.template.metadata.labels of type string)
goroutine 837 [running]:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@gnufied
Copy link
Member Author

gnufied commented Oct 4, 2023

/retest

@gnufied
Copy link
Member Author

gnufied commented Oct 4, 2023

Now it is failing on:

    util.go:807: 
        Unexpected error:
            <*errors.errorString | 0xc0006e6000>: 
            NeedManagementKASAccessLabel label is not allowed on component: aws-ebs-csi-driver-operator
            {
                s: "NeedManagementKASAccessLabel label is not allowed on component: aws-ebs-csi-driver-operator",
            }
        occurred
            --- FAIL: TestCreateClusterPrivate/EnsureHostedCluster/EnsureNetworkPolicies/EnsureComponentsHaveNeedManagementKASAccessLabel (0.01s)

I am checking with hypershift team about this.

@gnufied gnufied mentioned this pull request Oct 4, 2023
Closed
4 tasks
enxebre added a commit to enxebre/hypershift that referenced this pull request Oct 5, 2023
@enxebre
Add aws-ebs-csi-driver-operator to allowed NeedManagementKASAccessLab…
09842e8 
…el in test

This is needed now so openshift/cluster-storage-operator#403 can pass
@enxebre enxebre mentioned this pull request Oct 5, 2023
Merged
4 tasks
@gnufied
Copy link
Member Author

gnufied commented Oct 5, 2023

/retest

1 similar comment
@gnufied
Copy link
Member Author

gnufied commented Oct 5, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

@gnufied: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-csi b0971c5 link false /test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bryan-cox pushed a commit to bryan-cox/hypershift that referenced this pull request Oct 9, 2023
@enxebre @bryan-cox
Add aws-ebs-csi-driver-operator to allowed NeedManagementKASAccessLab…
c77e43a 
…el in test

This is needed now so openshift/cluster-storage-operator#403 can pass
@jsafrane
Copy link
Contributor

jsafrane commented Oct 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@openshift-ci openshift-ci bot merged commit 798c24c into openshift:master Oct 9, 2023
11 of 12 checks passed
@openshift-ci-robot
Copy link
Contributor

@gnufied: Jira Issue OCPBUGS-19073: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19073 has been moved to the MODIFIED state.

In response to this:

Fixes https://issues.redhat.com/browse/OCPBUGS-19073

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@ropatil010 ropatil010 Awaiting requested review from ropatil010

@mpatlasov mpatlasov Awaiting requested review from mpatlasov

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gnufied @openshift-ci-robot @ropatil010 @openshift-merge-robot @jsafrane