OCPBUGS-22443: manila: Add missing CSI_FSGROUP_POLICY env var #412
Conversation
This was mistakenly introduced to the wrong set of manifests in a previous change to the Manila CSI Driver Operator [1]. Correct this mistake. [1] openshift/csi-driver-manila-operator@660bbb7 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Cc: Francesco Pantano <fpantano@redhat.com>
openshift-ci-robot
added
jira/valid-reference
|
@stephenfin: This pull request references Jira Issue OCPBUGS-22443, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@stephenfin: This pull request references Jira Issue OCPBUGS-22443, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stephenfin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stephenfin in openshift/csi-driver-manila-operator#142 (comment) @gouthampacha it's for development and testing only. Is it now intended for cluster admins? You will need some API for that. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
still useful only for developers/testing @jsafrane @stephenfin |
|
The operator already uses a good default when it's not set. I think it makes very little sense to set the env. variable to the default value here. I am still not sure what do you want. You already have a quick & dirty env. variable for any testing you may need. If you want it usable by cluster admins, then please add a real Manila-specific API field to ClusterCSIDriver object - it already allows for driver specific configurations. |
|
tbc, I only added this because I wanted to remove the misleading assets from the Manila CSI Driver Operator. This is the sole addition on that side that is not reflected here, but from what I'm hearing we don't need/want this particular change here. If so, should I just abandon this and proceed with the removal of manifests from |
|
Yeah, I think this PR does not really belong here. And removing manifests from manila-csi-driver-operator is a good thing to do. |
|
@stephenfin: This pull request references Jira Issue OCPBUGS-22443. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was mistakenly introduced to the wrong set of manifests in a previous change to the Manila CSI Driver Operator [1]. Correct this mistake.
/cc @fmount
[1] openshift/csi-driver-manila-operator@660bbb7
Signed-off-by: Stephen Finucane stephenfin@redhat.com