Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1453: Grant permissions to access apiserver to CSI driver operators #415

Conversation

mpatlasov
Copy link
Contributor

@mpatlasov mpatlasov commented Nov 3, 2023

The operators need to get spec.tlsSecurityProfile from apiserver cluster to construct command-line options --tls-cipher-suites and --tls-min-version for kube RBAC proxy sidecars.

…ators

The operatos need to get `spec.tlsSecurityProfile` from apiserver cluster to construct command-line options `--tls-cipher-suites` and `--tls-min-version` for kube RBAC proxy sidecars.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2023

@mpatlasov: This pull request references STOR-1453 which is a valid jira issue.

In response to this:

The operatos need to get spec.tlsSecurityProfile from apiserver cluster to construct command-line options --tls-cipher-suites and --tls-min-version for kube RBAC proxy sidecars.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2023

@mpatlasov: This pull request references STOR-1453 which is a valid jira issue.

In response to this:

The operators need to get spec.tlsSecurityProfile from apiserver cluster to construct command-line options --tls-cipher-suites and --tls-min-version for kube RBAC proxy sidecars.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

@mpatlasov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-csi e1007f7 link false /test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

jsafrane commented Nov 6, 2023

/lgtm

@jsafrane
Copy link
Contributor

jsafrane commented Nov 6, 2023

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 6, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
@duanwei33
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 10, 2023

@mpatlasov: This pull request references STOR-1453 which is a valid jira issue.

In response to this:

The operators need to get spec.tlsSecurityProfile from apiserver cluster to construct command-line options --tls-cipher-suites and --tls-min-version for kube RBAC proxy sidecars.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4bb5466 into openshift:master Nov 10, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants