OCPVE-789: annotate credentials request manifests

[qJkee]

Add capability annotations to cloud credentials requests

[openshift-ci-robot]

@qJkee: This pull request references OCPVE-789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Add capability annotations to cloud credentials requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jsafrane]

@qJkee what should happen when Storage capability is set and CloudCredential is not on say AWS? Today, the cluster won't install, because the CSI driver does not get its Secret. CI is already complaining in this PR with a cryptic error AzureDiskDriverControllerServiceControllerAvailable: Waiting for Deployment AzureDiskCSIDriverOperatorCRAvailable: AzureDiskDriverNodeServiceControllerAvailable: Waiting for the DaemonSet to deploy the CSI Node Service.

I think we need some code to throw a more reasonable error like "Timed out waiting for Secret XYZ to be present," with an alert / docs about what it means.

[qJkee]

/retest

[qJkee]

/retest

[qJkee]

@jsafrane
That will be documented. This is not the only component which would fail in case when cloud credentials are not present at the cluster.

[jsafrane]

I am afraid documentation is not enough. Nobody reads it. It would be much better to say something in the operator conditions, so it bubbles up to oc get clusterversion, alerts, telemetry and so on.

[jsafrane]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/label px-approved

[qJkee]

/label docs-approved
labelling by myself because this is not the main PR for feature

[qJkee]

/label qe-approved
QE tested the feature, can be tracked via Jira links

[openshift-ci-robot]

@qJkee: This pull request references OCPVE-789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Add capability annotations to cloud credentials requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@qJkee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud-csi	469fbb7	link	unknown	/test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cfaf9e3 and 2 for PR HEAD 469fbb7 in total

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.16.0-202312080609.p0.gacbb807.assembly.stream for distgit cluster-storage-operator.
All builds following this will include this PR.