Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1722: Azure disk hypershift #420

Merged
merged 5 commits into from Jan 19, 2024
Merged

STOR-1722: Azure disk hypershift #420

merged 5 commits into from Jan 19, 2024

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Nov 20, 2023 •
edited

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@gnufied gnufied changed the title Azure disk hypershift STOR-1279: Azure disk hypershift Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1279 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1279 which is a valid jira issue.

In response to this:

Fixes STOR-1279

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Dec 1, 2023

/retest

@jsafrane
Copy link
Contributor

jsafrane commented Dec 1, 2023

/lgtm
Go code looks OK, CI on azure looks green-ish and I checked azure-disk-csi-driver-operator Deployment YAML from e2e-azure-csi run here is the same as in a previous run.

@jsafrane
Copy link
Contributor

jsafrane commented Dec 1, 2023 •
edited

This PR needs to be re-tested on HyperShift with openshift/csi-operator#73.
/hold for openshift/csi-operator#73 to be merged first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@gnufied
Copy link
Member Author

gnufied commented Dec 1, 2023

I have tested this PR with openshift/csi-operator#73 . I have in fact published a ocp build quay.io/gnufied/ocp:4.15 which includes both CSO and csi-operator changes and can be directly installed and tested in both standalone and hypershift environments.

@gnufied gnufied changed the title STOR-1279: Azure disk hypershift STOR-1713: Azure disk hypershift Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1713 which is a valid jira issue.

In response to this:

Fixes STOR-1279

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1713 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/STOR-1696

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gnufied gnufied changed the title STOR-1713: Azure disk hypershift STOR-1696: Azure disk hypershift Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1696 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/STOR-1696

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1696 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/STOR-1722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gnufied gnufied changed the title STOR-1696: Azure disk hypershift STOR-1722: Azure disk hypershift Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/STOR-1722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ropatil010
Copy link

Added the test results here: https://issues.redhat.com/browse/STOR-1707
/test e2e-ibmcloud-csi
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 18, 2024 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/STOR-1722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gnufied
Copy link
Member Author

gnufied commented Jan 19, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2024
@gnufied
Copy link
Member Author

gnufied commented Jan 19, 2024

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jan 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024 •
edited

@gnufied: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-csi 13c480c link false /test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d134e06 and 2 for PR HEAD 13c480c in total

@openshift-merge-bot openshift-merge-bot bot merged commit 321e452 into openshift:master Jan 19, 2024
12 of 13 checks passed
@gnufied gnufied deleted the azure-disk-hypershift branch January 19, 2024 17:23
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.16.0-202401191549.p0.g321e452.assembly.stream for distgit cluster-storage-operator.
All builds following this will include this PR.

@gnufied gnufied restored the azure-disk-hypershift branch February 1, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@mpatlasov mpatlasov Awaiting requested review from mpatlasov

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gnufied @openshift-ci-robot @jsafrane @ropatil010 @openshift-bot