New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-1277: Add Prometheus rules for SELinux telemetry #422
Conversation
@jsafrane: This pull request references STOR-1277 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
047a203
to
4b2068e
Compare
4b2068e
to
a47146a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The only comment I'd have is to consider using a different prefix to indicate this comes from the volume_manager.
Perhaps cluster:volume_manager:kube_selinux_
or cluster:volume_manager_selinux
.
Create new SELinux metrics to send through telemetry to remove all labels except for volume_plugin.
a47146a
to
8c3435e
Compare
Updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/hold cancel |
/label px-approved |
|
/label qe-approved |
@jsafrane: This pull request references STOR-1277 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
1 similar comment
/retest-required |
/retest-required |
@jsafrane: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold Revision 8c3435e was retested 3 times: holding |
/retest-required This PR seems to have really bad luck. |
/hold cancel |
cfaf9e3
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-storage-operator-container-v4.15.0-202312012031.p0.gcfaf9e3.assembly.stream for distgit cluster-storage-operator. |
Create new SELinux metrics to send through telemetry to remove all labels except for
volume_plugin
. See https://issues.redhat.com/browse/STOR-1277.cc @openshift/storage