Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1277: Add Prometheus rules for SELinux telemetry #422

Merged
merged 1 commit into from Dec 1, 2023

Conversation

jsafrane
Copy link
Contributor

Create new SELinux metrics to send through telemetry to remove all labels except for volume_plugin. See https://issues.redhat.com/browse/STOR-1277.

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2023

@jsafrane: This pull request references STOR-1277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Create new SELinux metrics to send through telemetry to remove all labels except for volume_plugin. See https://issues.redhat.com/browse/STOR-1277.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor Author

/hold
for the metrics to be approved

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
Copy link

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The only comment I'd have is to consider using a different prefix to indicate this comes from the volume_manager.
Perhaps cluster:volume_manager:kube_selinux_ or cluster:volume_manager_selinux.

Create new SELinux metrics to send through telemetry to remove all labels
except for volume_plugin.
@jsafrane
Copy link
Contributor Author

This looks good to me. The only comment I'd have is to consider using a different prefix to indicate this comes from the volume_manager. Perhaps cluster:volume_manager:kube_selinux_ or cluster:volume_manager_selinux.

Updated to cluster:volume_manager_selinux_*

Copy link

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor Author

/retest-required

@jsafrane
Copy link
Contributor Author

/hold cancel
@jan--f from monitoring team lgtm-ed.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@jsafrane
Copy link
Contributor Author

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 29, 2023
@chao007
Copy link

chao007 commented Nov 30, 2023

curl -G -k -H "Authorization: Bearer $token" \
https://$(oc get route prometheus-k8s-federate -n \
openshift-monitoring -o jsonpath="{.spec.host}")/federate \
--data-urlencode 'match[]={__name__=~"cluster:volume_manager_selinux_volumes_admitted_total"}'

# TYPE cluster:volume_manager_selinux_volumes_admitted_total untyped
cluster:volume_manager_selinux_volumes_admitted_total{volume_plugin="kubernetes.io/csi/ebs.csi.aws.com",instance="",prometheus="openshift-monitoring/k8s",prometheus_replica="prometheus-k8s-0"} 1 1701331867402
curl -G -k -H "Authorization: Bearer $token" \
https://$(oc get route prometheus-k8s-federate -n \
openshift-monitoring -o jsonpath="{.spec.host}")/federate \
--data-urlencode 'match[]={__name__=~"cluster:volume_manager_selinux_pod_context_mismatch_total"}'
# TYPE cluster:volume_manager_selinux_pod_context_mismatch_total untyped
cluster:volume_manager_selinux_pod_context_mismatch_total{instance="",prometheus="openshift-monitoring/k8s",prometheus_replica="prometheus-k8s-0"} 49 1701332137402

@chao007
Copy link

chao007 commented Nov 30, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 30, 2023

@jsafrane: This pull request references STOR-1277 which is a valid jira issue.

In response to this:

Create new SELinux metrics to send through telemetry to remove all labels except for volume_plugin. See https://issues.redhat.com/browse/STOR-1277.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 101f600 and 2 for PR HEAD 8c3435e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 297bfca and 1 for PR HEAD 8c3435e in total

@Phaow
Copy link

Phaow commented Dec 1, 2023

/retest-required

1 similar comment
@Phaow
Copy link

Phaow commented Dec 1, 2023

/retest-required

@Phaow
Copy link

Phaow commented Dec 1, 2023

/retest-required

Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-csi 8c3435e link false /test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 06dc1e7 and 0 for PR HEAD 8c3435e in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 8c3435e was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@jsafrane
Copy link
Contributor Author

jsafrane commented Dec 1, 2023

/retest-required

This PR seems to have really bad luck.

@jsafrane
Copy link
Contributor Author

jsafrane commented Dec 1, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 06dc1e7 and 2 for PR HEAD 8c3435e in total

@openshift-merge-bot openshift-merge-bot bot merged commit cfaf9e3 into openshift:master Dec 1, 2023
11 of 12 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.15.0-202312012031.p0.gcfaf9e3.assembly.stream for distgit cluster-storage-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants