Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1574: Bump library-go #443

Merged

Conversation

jsafrane
Copy link
Contributor

Update openshift/library-go and openshift/api to today's master. Update k8s deps to v0.29.0.
Manually bumped controller-runtime, it brought even newer k8s packages.

@openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024

@jsafrane: This pull request references STOR-1574 which is a valid jira issue.

In response to this:

Update openshift/library-go and openshift/api to today's master. Update k8s deps to v0.29.0.
Manually bumped controller-runtime, it brought even newer k8s packages.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
Update openshift/library-go and openshift/api to today's master. Update k8s deps to v0.29.0.
@jsafrane
Copy link
Contributor Author

/label px-approved
/label docs-approved
No changes from user perspective
/label qe-approved
CI should be enough for library bumps

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Jan 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024

@jsafrane: This pull request references STOR-1574 which is a valid jira issue.

In response to this:

Update openshift/library-go and openshift/api to today's master. Update k8s deps to v0.29.0.
Manually bumped controller-runtime, it brought even newer k8s packages.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-csi 2cc8234 link false /test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member

dobsonj commented Jan 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3ecca82 into openshift:master Jan 19, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants