Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29196: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions #455

Merged
merged 1 commit into from Feb 13, 2024

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Feb 12, 2024

This bumps openshift/api to get the new changes from openshift/api@04ea389
https://issues.redhat.com/browse/OCPBUGS-29196
go get github.com/openshift/api && go mod tidy && go mod vendor
/cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 12, 2024
@openshift-ci-robot
Copy link
Contributor

@dobsonj: This pull request references Jira Issue OCPBUGS-29196, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This bumps openshift/api to get the new changes from openshift/api@04ea389
https://issues.redhat.com/browse/OCPBUGS-29196
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Phaow February 12, 2024 17:24
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This bumps openshift/api to get the new changes from openshift/api@04ea389
https://issues.redhat.com/browse/OCPBUGS-29196
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Feb 12, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-parallel ed6ce48 link false /test e2e-openstack-parallel
ci/prow/e2e-ibmcloud-csi ed6ce48 link false /test e2e-ibmcloud-csi
ci/prow/e2e-openstack ed6ce48 link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member Author

dobsonj commented Feb 12, 2024

Quick test with this PR to show the CRD is updated and the new partition is accepted by the API server.

$ oc get crd clustercsidrivers.operator.openshift.io -o yaml | grep aws-iso
                        pattern: ^arn:(aws|aws-cn|aws-us-gov|aws-iso|aws-iso-b|aws-iso-e|aws-iso-f):kms:[a-z0-9-]+:[0-9]{12}:(key|alias)\/.*$

$ oc edit clustercsidriver ebs.csi.aws.com
clustercsidriver.operator.openshift.io/ebs.csi.aws.com edited

$ oc get clustercsidriver ebs.csi.aws.com -o json | jq .spec.driverConfig
{
  "aws": {
    "kmsKeyARN": "arn:aws-iso:kms:us-east-2:269733383066:alias/jdobson-kms01"
  },
  "driverType": "AWS"
}

$ oc get sc -o yaml | grep kmsKeyId
    kmsKeyId: arn:aws-iso:kms:us-east-2:269733383066:alias/jdobson-kms01
    kmsKeyId: arn:aws-iso:kms:us-east-2:269733383066:alias/jdobson-kms01

@mpatlasov
Copy link
Contributor

/lgtm
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Feb 13, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5789702 into openshift:master Feb 13, 2024
16 of 19 checks passed
@openshift-ci-robot
Copy link
Contributor

@dobsonj: Jira Issue OCPBUGS-29196: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29196 has been moved to the MODIFIED state.

In response to this:

This bumps openshift/api to get the new changes from openshift/api@04ea389
https://issues.redhat.com/browse/OCPBUGS-29196
go get github.com/openshift/api && go mod tidy && go mod vendor
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.16.0-202402131839.p0.g5789702.assembly.stream.el9 for distgit cluster-storage-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants