New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29573: Apply hypershift cluster-profile for ibm-cloud-managed #458
OCPBUGS-29573: Apply hypershift cluster-profile for ibm-cloud-managed #458
Conversation
@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29573, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
If any other file needs to be updated to support this change, please let me know. |
@ashwindasr you must update https://github.com/openshift/cluster-storage-operator/blob/master/profile-patches/ibm-cloud-managed/10_deployment.yaml-patch too. And |
0adbbb4
to
7b4d886
Compare
add hypershift annotation
@openshift-art-build-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, openshift-art-build-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
88ab658
into
openshift:master
@openshift-art-build-bot: Jira Issue OCPBUGS-29573: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29573 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-storage-operator-container-v4.16.0-202402221310.p0.g88ab658.assembly.stream.el9 for distgit cluster-storage-operator. |
Fix included in accepted release 4.16.0-0.nightly-2024-02-22-180402 |
Since HyperShift / Hosted Control Plane have adopted
include.release.openshift.io/ibm-cloud-managed
, to tailor the resources of clusters running in the ROKS IBM environment, theinclude.release.openshift.io/hypershift
addition will allow Hypershift to express different profile choices than ROKS