Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-482: set required-scc for openshift workloads #459

Merged
merged 1 commit into from Apr 12, 2024

Conversation

liouk
Copy link
Member

@liouk liouk commented Feb 20, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2024

@liouk: This pull request references AUTH-482 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor

/lgtm
/approve

@jsafrane
Copy link
Contributor

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@liouk
Copy link
Member Author

liouk commented Feb 22, 2024

Pinned SCC to one more workload (deployment of cluster-storage-operator).

@liouk liouk changed the title AUTH-482: set required-scc for openshift workloads WIP: AUTH-482: set required-scc for openshift workloads Feb 28, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@liouk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 9d2a57a link false /test e2e-openstack
ci/prow/e2e-ibmcloud-csi 9d2a57a link false /test e2e-ibmcloud-csi
ci/prow/e2e-openstack-parallel 9d2a57a link false /test e2e-openstack-parallel
ci/prow/e2e-gcp-manual-oidc 9d2a57a link false /test e2e-gcp-manual-oidc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2024

/lgtm

Remove WIP if it's ready to merge.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@liouk liouk changed the title WIP: AUTH-482: set required-scc for openshift workloads AUTH-482: set required-scc for openshift workloads Mar 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@jsafrane
Copy link
Contributor

/label px-approved
/label docs-approved
This is not user-facing change.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Apr 11, 2024
@jsafrane
Copy link
Contributor

For QE: this should result in no user visible change. It only forces the right SCCs to our components, so we avoid future issues like https://issues.redhat.com/browse/OCPBUGS-6992.

@dpuniaredhat
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2024

@liouk: This pull request references AUTH-482 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d86cdbc into openshift:master Apr 12, 2024
15 of 19 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.16.0-202404121144.p0.gd86cdbc.assembly.stream.el9 for distgit cluster-storage-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants