Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28748: log default storage class names when collector is triggered #460

Merged

Conversation

RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented Feb 21, 2024

It is more helpful to show which storage classes were detected as default. There's an alert when more than one default is present and this message might help debug such cases in the future.

Message example:

I0221 16:55:09.385977   65866 starter.go:63] Current default StorageClass count: 2 ([thin-csi thin-csi2])

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 21, 2024
@openshift-ci-robot
Copy link
Contributor

@RomanBednar: This pull request references Jira Issue OCPBUGS-28748, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

It is more helpful to show which storage classes were detected as default. There's an alert when more than one default is present and this message might help debug such cases in the future.

Message example:

I0221 16:55:09.385977   65866 starter.go:63] Current default StorageClass count: 2 ([thin-csi thin-csi2])

NOTE: prometheus collector does not seem to handle log levels too well and I could not see the message when using .V(4) - removing it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@jsafrane
Copy link
Contributor

NOTE: prometheus collector does not seem to handle log levels too well and I could not see the message when using .V(4) - removing it.

That's odd, I can see the log line just fine at level 4:

I0222 16:39:37.205256       1 starter.go:61] Current default StorageClass count 1

@jsafrane
Copy link
Contributor

Please put V(4) back. We can argue if V(2) would be more appropriate, but no log level is IMO bad.

It is more helpful to show which storage classes were detected as
default. There's an alert when more than one default is present and
this message might help debug such cases in the future.
@RomanBednar
Copy link
Contributor Author

I see, must have been a mistake while testing - corrected.

@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@RomanBednar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@RomanBednar: An error was encountered updating to the POST state for bug OCPBUGS-28748 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. It seems that you have tried to perform a workflow operation (POST) that is not valid for the current state of this issue (OCPBUGS-28748). The likely cause is that somebody has changed the issue recently, please look at the issue history for details.: request failed. Please analyze the request body for more details. Status code: 400:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 15, 2024
@openshift-ci-robot
Copy link
Contributor

@RomanBednar: This pull request references Jira Issue OCPBUGS-28748, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ropatil010

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from ropatil010 March 15, 2024 09:23
@RomanBednar
Copy link
Contributor Author

/label acknowledge-critical-fixes-only
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Mar 15, 2024
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 4bae49d link false /test e2e-openstack
ci/prow/e2e-ibmcloud-csi 4bae49d link false /test e2e-ibmcloud-csi
ci/prow/e2e-gcp-manual-oidc 4bae49d link false /test e2e-gcp-manual-oidc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c9d080e and 2 for PR HEAD 4bae49d in total

@openshift-merge-bot openshift-merge-bot bot merged commit 72452fc into openshift:master Mar 15, 2024
16 of 19 checks passed
@openshift-ci-robot
Copy link
Contributor

@RomanBednar: Jira Issue OCPBUGS-28748: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28748 has been moved to the MODIFIED state.

In response to this:

It is more helpful to show which storage classes were detected as default. There's an alert when more than one default is present and this message might help debug such cases in the future.

Message example:

I0221 16:55:09.385977   65866 starter.go:63] Current default StorageClass count: 2 ([thin-csi thin-csi2])

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.16.0-202403180813.p0.g72452fc.assembly.stream.el9 for distgit cluster-storage-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-21-152650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants