Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.14] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all curren #462

Merged

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Mar 5, 2024

https://issues.redhat.com/browse/OCPBUGS-30054

This PR bumps openshift/api to pull in openshift/api@3e8192a

Generated with:

go get github.com/openshift/api@release-4.14
go mod tidy && go mod vendor

/cc @openshift/storage @Phaow
/label backport-risk-assessed

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 5, 2024
@openshift-ci-robot
Copy link
Contributor

@dobsonj: This pull request references Jira Issue OCPBUGS-30054, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29370 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29370 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-30054

This PR bumps openshift/api to pull in openshift/api@3e8192a

Generated with:

go get github.com/openshift/api@release-4.14
go mod tidy && go mod vendor

/cc @openshift/storage @Phaow
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 5, 2024
@openshift-ci openshift-ci bot requested a review from Phaow March 5, 2024 16:21
@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 5, 2024
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-30054

This PR bumps openshift/api to pull in openshift/api@3e8192a

Generated with:

go get github.com/openshift/api@release-4.14
go mod tidy && go mod vendor

/cc @openshift/storage @Phaow
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-csi 1b13c17 link false /test e2e-azure-csi
ci/prow/e2e-gcp-manual-oidc 1b13c17 link false /test e2e-gcp-manual-oidc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@duanwei33
Copy link

Pre-merge testing passed with open PR:
Update clustercsidriver to add a kmsKeyARN with arn:aws-iso-b:kms:xxx which is not supported without the fix, the update action should be accepted without error and the kmsKeyARN is present.

$ oc edit clustercsidriver/ebs.csi.aws.com
clustercsidriver.operator.openshift.io/ebs.csi.aws.com edited

$ oc get clustercsidriver/ebs.csi.aws.com -ojson | jq .spec.driverConfig
{
  "aws": {
    "kmsKeyARN": "arn:aws-iso-b:kms:us-isob-east-1:123456789012:key/abcd1234-a123-456a-a12b-a123b4cd56ef"
  },
  "driverType": "AWS"
}

@duanwei33
Copy link

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 6, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Mar 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit aab7b5b into openshift:release-4.14 Mar 7, 2024
14 of 16 checks passed
@openshift-ci-robot
Copy link
Contributor

@dobsonj: Jira Issue OCPBUGS-30054: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30054 has been moved to the MODIFIED state.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-30054

This PR bumps openshift/api to pull in openshift/api@3e8192a

Generated with:

go get github.com/openshift/api@release-4.14
go mod tidy && go mod vendor

/cc @openshift/storage @Phaow
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.14.0-202403071941.p0.gaab7b5b.assembly.stream.el8 for distgit cluster-storage-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-03-08-015514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants