Bug 1858751: Fix installation on usupported platforms like oVirt #62
Conversation
The operator should mark itself as Available when on a platform that does not have a default StorageClass (yet).
openshift-ci-robot
added
the
approved
jsafrane
force-pushed
the
fix-ovirt-install
branch
from
6e98d3a
to
c800cfb
Compare
|
/test ci/prow/e2e-ovirt |
|
@eslutsky: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
| @@ -98,10 +98,13 @@ func (c *Controller) sync(ctx context.Context, syncCtx factory.SyncContext) erro | |||
| Reason: "UnsupportedPlatform", | |||
| Message: syncErr.Error(), | |||
| } | |||
| availableCnd.Message = "No default StorageClass for this platform" | |||
There was a problem hiding this comment.
Could you add a brief comment saying why we set it to true (like the above)?
After reading the message, one may assume the condition is wrong
There was a problem hiding this comment.
A comment added, PTAL
jsafrane
force-pushed
the
fix-ovirt-install
branch
2 times, most recently
from
017180d
to
7415fa2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jsafrane
changed the title
|
@jsafrane: All pull requests linked via external trackers have merged: . Bugzilla bug 1858751 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The operator should mark itself as
Availablewhen on a platform that does not have a default StorageClass (yet).library-go status syncer expects at least Available condition in
storageCR to mark the OperatorStatus asAvailable.cc @openshift/storage