Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NFS driver deployment #67

Merged
merged 1 commit into from Aug 3, 2020

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Aug 3, 2020

Pass NFS driver image name to Manila operator.

Fixes this error in Manila CSI driver Deployment:

    Failed to apply default image tag "${NFS_DRIVER_IMAGE}": couldn't parse
    image reference "${NFS_DRIVER_IMAGE}": invalid reference format:
    repository name must be lowercase

@openshift/storage

Pass NFS driver image name to Manila operator.

Fixes this error in Manila CSI driver Deployment:
    Failed to apply default image tag "${NFS_DRIVER_IMAGE}": couldn't parse
    image reference "${NFS_DRIVER_IMAGE}": invalid reference format:
    repository name must be lowercase
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 3, 2020

/test e2e-openstack

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 3, 2020

/test e2e-openstack

@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 3, 2020

/test e2e-aws
/test e2e-openstack

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bertinatto,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2020
@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 3, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@jsafrane: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack cbc27ce link /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d28ecb1 into openshift:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants