Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to openshift-manila-csi-driver namespace #68

Merged
merged 1 commit into from Aug 3, 2020
Merged

Move to openshift-manila-csi-driver namespace #68

merged 1 commit into from Aug 3, 2020

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Aug 3, 2020 •
edited

As Manila CSI driver moves to openshift-manila-csi-driver, CSO must update
some code too:

  • Manila operator must have permissions to create/update secrets in openshift-manila-csi-driver namespace to be able to translate OpenStack credentials to the format required by Manila.
  • Manila operator will need to create CredentialsRequest for the driver (because now it's in a separate NS). Therefore CSO should use another name for the operator's CredentialsRequest, so the name implies it's for the operator only.

@jsafrane
Move to openshift-manila-csi-driver namespace
1aaa982 
As Manila CSI driver moves to openshift-manila-csi-driver, CSO must update
some code too:

- Manila operator must have permissions to create/update secrets in
  openshift-manila-csi-driver namespace.
- Manila operator should use different CredentialsRequest that the driver.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
bertinatto
bertinatto reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bertinatto,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4d0e19e into openshift:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@gnufied gnufied Awaiting requested review from gnufied

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsafrane @openshift-ci-robot @bertinatto @openshift-merge-robot