Bug 1862523: Add migration controller #69
Conversation
OLMOperatorRemovalController removes CSI driver operator from OLM. It must run before CSO starts CSI driver operator to make sure only one operator / only one driver runs at a time.
jsafrane
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@jsafrane: This pull request references Bugzilla bug 1862523, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
cc @openshift/storage |
| subNamespace, subName, csvName, found, err := c.findSubscription(ctx) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Is there a way to short-circuit here in case everything has been deleted already?
Edit: CSI migration logic adds a "migrated" annotation to CSINode once the node has been migrated, would that work here?
Edit: to clarify: add an annotation to the CR so we can short-circuit here
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jsafrane: All pull requests linked via external trackers have merged: openshift/cluster-storage-operator#69. Bugzilla bug 1862523 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OLMOperatorRemovalController removes CSI driver operator from OLM. It must run before CSO starts CSI driver operator to make sure only one operator / only one driver runs at a time.
It removes Subscription, CSV, waits for the old operator Deployment to get removed by OLM and finally it force-removes the old CR (by clearing all its finalizers).
It signalizes that it's finished with OLM removal by setting
ManilaOLMOperatorRemovalAvailable: true. This is then recognized by CSIDriverStarterController that runs the new operator.