New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1865769: Remove authentication rolebinding #71
Bug 1865769: Remove authentication rolebinding #71
Conversation
CSO is cluster-admin anyway and can read anything.
@jsafrane: This pull request references Bugzilla bug 1865769, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have two files prefixed with 01: 01_cluster_csi_driver_crd.yaml
and 01_crd_operator.yaml
Edit: and other two prefixed with 03
. Can we take the chance and rename those?
To have increasing sequence
I reordered the manifests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jsafrane: All pull requests linked via external trackers have merged: openshift/cluster-storage-operator#71. Bugzilla bug 1865769 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CSO is cluster-admin and can read anything, therefore it does not need an extra role to read stuff in kube-system namespace
@openshift/storage