New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1882394: UPSTREAM: <carry>: operator-sdk: return error if lock is not leader-for-life #96
Bug 1882394: UPSTREAM: <carry>: operator-sdk: return error if lock is not leader-for-life #96
Conversation
@bertinatto: This pull request references Bugzilla bug 1882394, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4351a1a
to
7f663ff
Compare
There is no 4.6 counterpart, the bug is only in 4.5 |
@bertinatto: This pull request references Bugzilla bug 1882394, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1882394, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1882394, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1882394, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
patch manager: please take this for the next z-stream, it came very late in 4.5.z cycle. |
@bertinatto: All pull requests linked via external trackers have merged: Bugzilla bug 1882394 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In a 4.6 -> 4.5 downgrade scenario, CSO 4.5 could be started before CSO 4.6 is terminated.
This could happen:
ConfigMap
ConfigMap
was created by CSO 4.6, so it deletes it and continues to initializeConfigMap
was deleted and quickly re-created itConfigMap
, but that fails because another object with the same name existsThis patch introduces a check in the legacy operator-sdk code to prevent CSO 4.5 from getting stuck in the loop described in step 6 above.