Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1788155: get ipv6 support from library-go bump; switch to go modules #77

Merged

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Feb 24, 2020

No description provided.

Bumped library-go to pull in the fix for Bug 1788521.
PR: openshift/library-go#657

The default bind network was tcp4, library-go switch it to tcp
which will support ipv6.

The bug states the following:

   We use SetRecommendedServingInfoDefaults() in library-go across
   all operators to provide defaults for API servers that those
   operators run to serve metrics and healthz

Also pinned openshift/api & openshift/client-go to match the release.
@openshift-ci-robot
Copy link

@jmrodri: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug1788155 ipv6 metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmrodri jmrodri changed the title Bug1788155 ipv6 metrics Bug 1788155: get ipv6 support from library-go bump; switch to go modules Feb 24, 2020
@openshift-ci-robot
Copy link

@jmrodri: This pull request references Bugzilla bug 1788155, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1788155: get ipv6 support from library-go bump; switch to go modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 24, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 24, 2020

Depends on PR openshift/release#7298

@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 26, 2020

/retest

Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9a0689b into openshift:release-4.4 Feb 26, 2020
@jmrodri jmrodri deleted the bug1788155-ipv6-metrics branch March 25, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants