New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1788155: get ipv6 support from library-go bump #70
Bug 1788155: get ipv6 support from library-go bump #70
Conversation
Bumped library-go to pull in the fix for Bug 1788521. PR: openshift/library-go#657 The default bind network was tcp4, library-go switch it to tcp which will support ipv6. The bug states the following: We use SetRecommendedServingInfoDefaults() in library-go across all operators to provide defaults for API servers that those operators run to serve metrics and healthz
@jmrodri: This pull request references Bugzilla bug 1788155, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@jmrodri: This pull request references Bugzilla bug 1788155, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold need some updates to deal with library-go changes. |
Depends on PR openshift/release#7298 |
/retest |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianvf, jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jmrodri: All pull requests linked via external trackers have merged. Bugzilla bug 1788155 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bumped library-go to pull in the fix for Bug 1788521.
PR: openshift/library-go#657
The default bind network was tcp4, library-go switch it to tcp
which will support ipv6.
The bug states the following:
We use SetRecommendedServingInfoDefaults() in library-go across
all operators to provide defaults for API servers that those
operators run to serve metrics and healthz