Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1788155: get ipv6 support from library-go bump #70

Merged

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Feb 20, 2020

Bumped library-go to pull in the fix for Bug 1788521.
PR: openshift/library-go#657

The default bind network was tcp4, library-go switch it to tcp
which will support ipv6.

The bug states the following:

We use SetRecommendedServingInfoDefaults() in library-go across
all operators to provide defaults for API servers that those
operators run to serve metrics and healthz

Bumped library-go to pull in the fix for Bug 1788521.
PR: openshift/library-go#657

The default bind network was tcp4, library-go switch it to tcp
which will support ipv6.

The bug states the following:

   We use SetRecommendedServingInfoDefaults() in library-go across
   all operators to provide defaults for API servers that those
   operators run to serve metrics and healthz
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 20, 2020
@openshift-ci-robot
Copy link

@jmrodri: This pull request references Bugzilla bug 1788155, which is invalid:

  • expected Bugzilla bug 1788155 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1788155: get ipv6 support from library-go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 20, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 20, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 20, 2020
@openshift-ci-robot
Copy link

@jmrodri: This pull request references Bugzilla bug 1788155, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 20, 2020
@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 20, 2020

/hold need some updates to deal with library-go changes.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2020
@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 24, 2020

Depends on PR openshift/release#7298

@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 26, 2020

/retest

@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 26, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 72383b5 into openshift:release-4.4 Feb 26, 2020
@openshift-ci-robot
Copy link

@jmrodri: All pull requests linked via external trackers have merged. Bugzilla bug 1788155 has been moved to the MODIFIED state.

In response to this:

Bug 1788155: get ipv6 support from library-go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants