Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create-only annotation #74

Merged
merged 1 commit into from Apr 7, 2020

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Apr 7, 2020

To prevent CVO from attempting to update the Jobs during an upgrade, use create only annotation.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@jmrodri
Copy link
Contributor Author

jmrodri commented Apr 7, 2020

We have seen upgrade work on the apiserver job PR with create-only enabled. openshift/cluster-svcat-apiserver-operator#82 (comment)

@jmrodri
Copy link
Contributor Author

jmrodri commented Apr 7, 2020

@jmrodri
Copy link
Contributor Author

jmrodri commented Apr 7, 2020

/retest

@jmrodri
Copy link
Contributor Author

jmrodri commented Apr 7, 2020

/test images

@jmrodri jmrodri requested review from wking and jottofar April 7, 2020 13:45
@joelanford
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ce5f475 into openshift:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants