Skip to content

Commit

Permalink
Merge pull request #976 from openshift-cherrypick-robot/cherry-pick-9…
Browse files Browse the repository at this point in the history
…75-to-release-4.14

[release-4.14] OCPBUGS-19921: pkg/clusterconditions/cache: Avoid panic on all-fresh-cache evaluation
  • Loading branch information
openshift-ci[bot] committed Oct 8, 2023
2 parents e3531ce + b2a9265 commit a091f80
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/clusterconditions/cache/cache.go
Expand Up @@ -116,6 +116,8 @@ func (c *Cache) Match(ctx context.Context, condition *configv1.ClusterCondition)
detail = fmt.Sprintf(" (last evaluated on %s)", thiefResult.When)
}
klog.V(2).Infof("%s is the most stale cached cluster-condition match entry, but it is too fresh%s. However, we don't have a cached evaluation for %s, so attempt to evaluate that now.", thiefKey, detail, key)
thiefKey = key
targetCondition = condition
}

// if we ended up stealing this Match call, log that, to make contention more clear
Expand Down

0 comments on commit a091f80

Please sign in to comment.