Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getOverrideForManifest does not check manifest.GVK.Group #688

Closed
mbarnes opened this issue Nov 11, 2021 · 0 comments · Fixed by #689
Closed

getOverrideForManifest does not check manifest.GVK.Group #688

mbarnes opened this issue Nov 11, 2021 · 0 comments · Fixed by #689

Comments

@mbarnes
Copy link
Contributor

mbarnes commented Nov 11, 2021

We have the following override in our ClusterVersion:

    - group: imageregistry.operator.openshift.io
      kind: Config
      name: cluster
      namespace: ""
      unmanaged: true

This is causing cluster provisioning to fail, because when the operator encounters this manifest...

0000_30_config-operator_01_operator.cr.yaml

apiVersion: operator.openshift.io/v1
kind: Config
metadata:
  name: cluster
  annotations:
    include.release.openshift.io/ibm-cloud-managed: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
    release.openshift.io/create-only: "true"
spec:
  managementState: Managed

... the getOverrideForManifest function is improperly matching it to the above imageregistry.operator.openshift.io override because it disregards the Group in its comparison (imageregistry.operator.openshift.io != operator.openshift.io).

As a result, the cluster-config-operator has no custom resource to act on and it blocks the cluster-version-operator from ever completing:

$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version             False       True          3h18m   Working towards 4.9.7: 725 of 735 done (98% complete), waiting on config-operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant