Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-1169: deps: bump openshift/api and k8s.io/client.go #1022

Conversation

petr-muller
Copy link
Member

Created with:

$ go get github.com/openshift/api
$ go get k8s.io/client-go@v0.29.0
$ go mod tidy
$ go mod vendor

I needed to bump the k8s.io/client.go as well because without that bump
I was getting:

go: github.com/openshift/cluster-version-operator/pkg/cvo imports
	k8s.io/client-go/kubernetes/scheme imports
	k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.29.0), but does not contain package k8s.io/api/flowcontrol/v1alpha

Created with:

```
$ go get github.com/openshift/api
$ go get k8s.io/client-go@v0.29.0
$ go mod tidy
$ go mod vendor
```

I needed to bump the k8s.io/client.go as well because without that bump
I was getting:

```
go: github.com/openshift/cluster-version-operator/pkg/cvo imports
	k8s.io/client-go/kubernetes/scheme imports
	k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.29.0), but does not contain package k8s.io/api/flowcontrol/v1alpha
```
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024

@petr-muller: This pull request references OTA-1169 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Created with:

$ go get github.com/openshift/api
$ go get k8s.io/client-go@v0.29.0
$ go mod tidy
$ go mod vendor

I needed to bump the k8s.io/client.go as well because without that bump
I was getting:

go: github.com/openshift/cluster-version-operator/pkg/cvo imports
  k8s.io/client-go/kubernetes/scheme imports
  k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.29.0), but does not contain package k8s.io/api/flowcontrol/v1alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@petr-muller
Copy link
Member Author

   * could not run steps: step e2e-agnostic-operator failed: "e2e-agnostic-operator" post steps failed: failed to create or restart e2e-agnostic-operator-ipi-deprovision-deprovision pod: unable to create pod: Internal error occurred: resource quota evaluation timed out 

/retest
Looks like build05 had a hiccup, from https://prow.ci.openshift.org/?cluster=build05 it looks it may be temporary

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Jan 17, 2024

openshift/release#47783 merged.

/test lint

@petr-muller
Copy link
Member Author

/retest

@petr-muller
Copy link
Member Author

/hold

This saw more failures than I feel comfortable with, I want to look at results before it merges even if the last retest is green

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member Author

Looking at https://prow.ci.openshift.org/pr-history/?org=openshift&repo=cluster-version-operator&pr=1022:

  • azure issue 1 2
  • build05 issue 1 2 3 4
  • installation failure, does not seem CVO-related 1

So no actual test failure, just a single installation fail that seems unrelated to CVO. Looks good to me.

@petr-muller
Copy link
Member Author

/hold cancel
/label no-qe

Labeling as no-qe because there is no new functionality. I do not consider this bump risky enough to do a dedicated regression run before merge (it is also early in the cycle).

@openshift-ci openshift-ci bot added no-qe Allows PRs to merge without qe-approved label and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 278dfd0 into openshift:master Jan 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. no-qe Allows PRs to merge without qe-approved label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants