New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA-1169: deps: bump openshift/api and k8s.io/client.go #1022
OTA-1169: deps: bump openshift/api and k8s.io/client.go #1022
Conversation
Created with: ``` $ go get github.com/openshift/api $ go get k8s.io/client-go@v0.29.0 $ go mod tidy $ go mod vendor ``` I needed to bump the k8s.io/client.go as well because without that bump I was getting: ``` go: github.com/openshift/cluster-version-operator/pkg/cvo imports k8s.io/client-go/kubernetes/scheme imports k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.29.0), but does not contain package k8s.io/api/flowcontrol/v1alpha ```
@petr-muller: This pull request references OTA-1169 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift/release#47783 merged. /test lint |
/retest |
/hold This saw more failures than I feel comfortable with, I want to look at results before it merges even if the last retest is green |
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold cancel Labeling as no-qe because there is no new functionality. I do not consider this bump risky enough to do a dedicated regression run before merge (it is also early in the cycle). |
Created with:
I needed to bump the k8s.io/client.go as well because without that bump
I was getting: