New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotations to manifests to exclude in hosted deployment #269
Add annotations to manifests to exclude in hosted deployment #269
Conversation
@@ -3,6 +3,8 @@ kind: Deployment | |||
metadata: | |||
name: cluster-version-operator | |||
namespace: openshift-cluster-version | |||
annotations: | |||
exclude.release.openshift.io/internal-openshift-hosted: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why internal-openshift-hosted
? Wouldn't this be internal-cluster-version-operator
or some such? Then folks can drop components with #252 and EXCLUDE_MANIFESTS=internal-cluster-version-operator,.whatever,others,they,need-to-exclude
. Or if we want a single knob for all the exclusions you need, we probably want docs (at least in the PR/commit message) for the intended components that fall under internal-openshift-hosted
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal-openshift-hosted
is the profile that this exclusion is for ( a hosted control plane deployment as opposed to a traditional self-hosted one ). It doesn't prevent us from excluding the same manifest for other "profiles" such as single-node.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Enables the CVO to exclude manifests in an externally hosted control plane deployment
See #252