Bug 1834568: Add cert to service to support https #366
Conversation
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1809195 is to add https metrics target. The PR to fix that bug is failing CI upgrade test since the 0001_00_cluster-version-operator_03_service with the service.beta.openshift.io/serving-cert-secret-name annotation is coming too late. So the monitoring tools aren't creating the secret causing the CVO container to fail to start. This PR adds the annotation to the service so that change can be fielded ahead of remaining changes necessary to support https target.
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@jottofar: This pull request references Bugzilla bug 1834568, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
|
/cc @wking |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-high
|
@jottofar: This pull request references Bugzilla bug 1834568, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jottofar: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#366. Bugzilla bug 1834568 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.4 |
|
@wking: new pull request created: #367 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1809195 is to add
https metrics target. The PR to fix that bug is failing CI upgrade
test since the 0001_00_cluster-version-operator_03_service with the
service.beta.openshift.io/serving-cert-secret-name annotation is
coming too late. So the monitoring tools aren't creating the secret
causing the CVO container to fail to start.
This PR adds the annotation to the service so that change can be
fielded ahead of remaining changes necessary to support https
target.