Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: Port to blang/semver v4 #405

Merged
merged 1 commit into from Jul 16, 2020
Merged

vendor: Port to blang/semver v4 #405

merged 1 commit into from Jul 16, 2020

Conversation

wking
Copy link
Member

@wking wking commented Jul 10, 2020 •
edited

Landed as a separate module back in May: blang/semver@af3461a9cbcf1f3. Doesn't seem to have any API changes that impact us though. Generated with:

$ go get -u github.com/blang/semver/v4@v4.0.0
go: downloading github.com/blang/semver/v4 v4.0.0
$ sed -i 's|semver"|semver/v4"|' $(git grep -l blang/semver -- lib pkg)
$ go mod tidy
$ go mod vendor
$ git add -A go.* lib pkg vendor

using:

$ go version
go version go1.14.4 linux/amd64

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@wking
vendor: Port to blang/semver v4
d67ef31 
Landed as a separate module back in May [1].  Doesn't seem to have any
API changes that impact us though.  Generated with:

  $ go get -u github.com/blang/semver/v4@v4.0.0
  go: downloading github.com/blang/semver/v4 v4.0.0
  $ sed -i 's|semver"|semver/v4"|' $(git grep -l blang/semver -- lib pkg)
  $ go mod tidy
  $ go mod vendor
  $ git add -A go.* lib pkg vendor

using:

  $ go version
  go version go1.14.4 linux/amd64

[1]: blang/semver@af3461a
@wking wking mentioned this pull request Jul 10, 2020
Merged
vrutkovs
vrutkovs approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

LalatenduMohanty
LalatenduMohanty approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,vrutkovs,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 28e4400 into openshift:master Jul 16, 2020
@wking wking deleted the semver-dep-bump branch July 23, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@jottofar jottofar Awaiting requested review from jottofar

Assignees

@vrutkovs vrutkovs

@LalatenduMohanty LalatenduMohanty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wking @openshift-bot @openshift-ci-robot @vrutkovs @LalatenduMohanty @openshift-merge-robot