Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context to add timeout to cincinnati HTTP request #410

Merged
merged 1 commit into from Jul 31, 2020
Merged

Use context to add timeout to cincinnati HTTP request #410

merged 1 commit into from Jul 31, 2020

Commits on Jul 30, 2020

  1. Use context to add timeout to cincinnati HTTP request 

    Change CVO wait.Until instances to wait.UntilWithContext making top-level
context available to the lower levels of the code. Use the added context
to add a timeout to the remote cincinnati HTTP call which has the
potential to hang the caller at the mercy of the target server.

The timeout has been set to an hour which was determined to be long
enough to allow all expected well-behaved requests to complete but short
enough to not be catastrophic if the calling thread were to hang.
    @lucab @jottofar
    lucab authored and jottofar committed Jul 30, 2020
    Copy the full SHA
    1d1de3b View commit details
    Browse the repository at this point in the history