Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CVO to inject internal loadbalancer for use by the CVO pod #412

Merged
merged 1 commit into from Jul 22, 2020
Merged

update CVO to inject internal loadbalancer for use by the CVO pod #412

merged 1 commit into from Jul 22, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 22, 2020 •
edited

During upgrades and kube-apiserver rollouts, the localhost connection can become
unavailable for multiple minutes. Using the internal loadbalancer prevents the
outage and lease loss.

/hold

unit tests are owed, so I'm holding the PR, but I'd like to demonstrate the idea and see how CI reacts.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Jul 22, 2020

from the CI run

    env:
    - name: KUBERNETES_SERVICE_PORT
      value: "443"
    - name: KUBERNETES_SERVICE_HOST
      value: api-int.ci-op-z0zhpvh0-11cd2.origin-ci-int-gce.dev.openshift.com

so it substituted, but got

2020-07-22T15:06:17.196524747Z E0722 15:06:17.196365 1 leaderelection.go:331] error retrieving resource lock openshift-cluster-version/version: Get https://api-int.ci-op-z0zhpvh0-11cd2.origin-ci-int-gce.dev.openshift.com:443/api/v1/namespaces/openshift-cluster-version/configmaps/version: dial tcp 10.0.0.2:443: connect: connection refused

because the port is 6443. I'll update and write unit tests.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 22, 2020

/hold cancel

now with tests and port detection.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
wking
wking reviewed Jul 22, 2020
View reviewed changes
lib/resourcebuilder/apps.go Outdated Show resolved Hide resolved
wking
wking reviewed Jul 22, 2020
View reviewed changes
lib/resourcebuilder/apps.go Outdated Show resolved Hide resolved
wking
wking reviewed Jul 22, 2020
View reviewed changes
lib/resourcebuilder/apps.go Outdated Show resolved Hide resolved
wking
wking reviewed Jul 22, 2020
View reviewed changes
lib/resourcebuilder/apps.go Outdated Show resolved Hide resolved
@LalatenduMohanty
Copy link
Member

Apart from #412 and #412 the PR looks good to me.

wking
wking reviewed Jul 22, 2020
View reviewed changes
lib/resourcebuilder/apps.go Outdated Show resolved Hide resolved
@deads2k
update CVO to inject internal loadbalancer for use by the CVO pod
f0f00ff 
During upgrades and kube-apiserver rollouts, the localhost connection can become
unavailable for multiple minutes. Using the internal loadbalancer prevents the
outage and lease loss.
@wking wking mentioned this pull request Jul 22, 2020
Merged
@sdodson
Copy link
Member

sdodson commented Jul 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2020
@wking
Copy link
Member

wking commented Jul 22, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c9fe488 into openshift:master Jul 22, 2020
@openshift-ci-robot
Copy link
Contributor

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e f0f00ff link /test e2e
ci/prow/e2e-upgrade f0f00ff link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson sdodson left review comments

@wking wking wking left review comments

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

Assignees

@sdodson sdodson

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@deads2k @LalatenduMohanty @sdodson @wking @openshift-ci-robot @openshift-merge-robot