Dockerfile*: Bump to Go 1.14 #414
Conversation
openshift-ci-robot
added
the
approved
Other components have already moved, such as the installer in openshift/installer@46a5f49709 (bump the minimum version for building installer to go 1.14, 2020-06-04, openshift/installer#3723). This will make enforcing Go 1.14 formatting more consistent, per discussion in [1]. [1]: https://github.com/openshift/cluster-version-operator/pull/411/files#r458821597
Generated with: $ go mod vendor using: $ go version go version go1.14.4 linux/amd64 addressing [1]: Building github.com/openshift/cluster-version-operator (v1.0.0-302-g13e97af4-dirty) # golang.org/x/text/unicode/norm vendor/golang.org/x/text/unicode/norm/composition.go:466:2: undefined: recompMapOnce ... I'd guessed these slipped through in 2021b86 (Bug 1855577: Updating the golang.org/x/text version to v0.3.3, 2020-07-15, openshift#408). $ go1.13.5 mod vendor pulls them in too, so I'm not entirely clear on how they slipped through. But they seem to be fatal for 1.14 builds and non-fatal for 1.13 builds. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/414/pull-ci-openshift-cluster-version-operator-master-images/1286049697189859328
|
/test e2e-upgrade |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
+1 to override |
|
/override ci/prow/e2e-upgrade |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Other components have already moved, such as the installer in openshift/installer@46a5f49709 (openshift/installer#3723). This will make enforcing Go 1.14 formatting more consistent, per discussion here.