Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Port from Update to Release for ClusterVersion status #419

Merged
merged 2 commits into from Aug 1, 2020

Commits on Jul 31, 2020

  1. vendor: Bump openshift/api to pick up the new Release type

    Pulling in [1].  Generated with:
    
      $ go get github.com/openshift/api@3ae6754513d463cb06af78e70c9b33bab6515ac7
      go: github.com/openshift/api 3ae6754513d463cb06af78e70c9b33bab6515ac7 => v0.0.0-20200724204552-3ae6754513d4
      $ go mod tidy
      $ go mod vendor
      $ git add -A go.* vendor
    
    using:
    
      $ go version
      go version go1.14.4 linux/amd64
    
    [1]: openshift/api@3ae6754
    wking committed Jul 31, 2020
    Copy the full SHA
    7bae18c View commit details
    Browse the repository at this point in the history
  2. *: Port from Update to Release for ClusterVersion status

    The next/last Actual comparison avoids:
    
      invalid operation: next.Actual == last.Actual (struct containing []string cannot be compared)
    
    The image pullspec is sufficient for that matching.  The test suite's
    expected LastProgress changes are because the shift from:
    
      {Version: "4.0.1", Image: "image/image:1"}
    
    to:
    
      {Version: "1.0.0-abc", Image: "image/image:1"}
    
    no longer counts as a LastProgress-bumping change (because we're now
    only comparing the Image pullspecs).
    
    Also adjusts the upstream/Cincinnati retrieval and payload loading
    logic to preserve the additional metadata that we're now exposing.
    Storing a Release on the Operator, instead of extending the previous
    releaseVersion/releaseImage pattern, makes it easy to keep track of
    payload-loaded metadata, so we can fall-back to upstream metadata for
    properties where the payload has no opinion, as described in the
    enhancement.
    
    In findUpdateFromConfigVersion, if some crazy upstream service
    declared a node with a matching version but no image, we used to say
    "sorry, no match" without looking through history.  Now we skip the
    useless entry and move on to consider later entries and history.  We
    only say "no match" if we have no image pullspec associated with the
    requested version available.
    wking committed Jul 31, 2020
    Copy the full SHA
    58356de View commit details
    Browse the repository at this point in the history