Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1906100: use child context to verify payload signature on forced update #493

Merged
merged 1 commit into from Jan 14, 2021
Merged

Bug 1906100: use child context to verify payload signature on forced update #493

merged 1 commit into from Jan 14, 2021

Conversation

jottofar
Copy link
Contributor

@jottofar jottofar commented Jan 7, 2021 •
edited

When '--force' is specified for an update, create new context with reduced timeout for use in signature verification to allow time to perform update.

The currently used context's timeout is set by SyncWorker Start based on an initial interval of 2 to ~4 minutes modified based on work.State and can therefore range from 2 to ~8 minutes. My testing found that during verify payload it had a 5 to 6 minute deadline. I therefore created a child context with a timeout of half that value when --force is specified.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
@jottofar
Copy link
Contributor Author

jottofar commented Jan 8, 2021

/retest

@jottofar
Copy link
Contributor Author

jottofar commented Jan 8, 2021

/test e2e-agnostic-upgrade

@jottofar jottofar force-pushed the bug-1906100 branch 2 times, most recently from e20f46d to 1925f4f Compare January 8, 2021 21:35
@jottofar jottofar changed the title WIP: pkg/cvo/updatepayload.go: use child context to retrieve payload Bug 1906100: use child context to verify payload signature on forced update Jan 8, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 8, 2021
@openshift-ci-robot
Copy link
Contributor

@jottofar: This pull request references Bugzilla bug 1906100, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1906100: use child context to verify payload signature on forced update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@jottofar: This pull request references Bugzilla bug 1906100, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1906100: use child context to verify payload signature on forced update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jottofar
Copy link
Contributor Author

jottofar commented Jan 9, 2021

/test e2e-agnostic

@openshift-ci-robot
Copy link
Contributor

@jottofar: This pull request references Bugzilla bug 1906100, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1906100: use child context to verify payload signature on forced update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jan 13, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 13, 2021
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1906100, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 13, 2021
@wking
Copy link
Member

wking commented Jan 13, 2021

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit efde32d into openshift:master Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

@jottofar: All pull requests linked via external trackers have merged:

Bugzilla bug 1906100 has been moved to the MODIFIED state.

In response to this:

Bug 1906100: use child context to verify payload signature on forced update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jan 20, 2021

/cherrypick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 20, 2021
Merged
@openshift-cherrypick-robot
Copy link

@wking: new pull request created: #504

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/cluster-version-operator that referenced this pull request Feb 3, 2021
@wking
pkg/cvo/updatepayload: Fix "verifcation" -> "verification" typo
44ea750 
Snuck into the logs with 687686e (pkg/cvo/updatepayload.go: use
child context to retrieve payload, 2021-01-07, openshift#493).
@wking wking mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jottofar @openshift-ci-robot @wking @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot