Bug 1768255: replace Fraction with Done and Total #497
Conversation
openshift-ci-robot
added
the
bugzilla/severity-low
|
@jottofar: This pull request references Bugzilla bug 1768255, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@jottofar: This pull request references Bugzilla bug 1768255, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jottofar
changed the title
|
@jottofar: This pull request references Bugzilla bug 1768255, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-agnostic |
openshift-ci-robot
added
the
do-not-merge/hold
|
I left a few minor nits and questions inline; overall looks great to me :). update jobs use A->B->A rollback testing: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/497/pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade/1351187522234880000/artifacts/e2e-agnostic-upgrade/gather-extra/clusterversion.json | jq -r '.items[].status.history[] | .startedTime + " " + (.completionTime // "-") + " " + .state + " " + .version + " " + (.verified | tostring)'
2021-01-18T16:39:08Z 2021-01-18T17:19:33Z Completed 4.7.0-0.ci.test-2021-01-18-152125-ci-op-djqib51v false
2021-01-18T16:03:13Z 2021-01-18T16:39:08Z Partial 4.7.0-0.ci.test-2021-01-18-152608-ci-op-djqib51v false
2021-01-18T15:35:09Z 2021-01-18T15:59:12Z Completed 4.7.0-0.ci.test-2021-01-18-152125-ci-op-djqib51v falseSo 16:03:13Z through 16:39:08Z should have the new messages. And it does: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/497/pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade/1351187522234880000/artifacts/e2e-agnostic-upgrade/openshift-e2e-test/e2e.log | grep ' 16:\([02]\|3[0-8]\).*% complete' | sort
Jan 18 16:03:48.517: INFO: cluster upgrade is Progressing: Working towards 4.7.0-0.ci.test-2021-01-18-152608-ci-op-djqib51v: 4 of 662 done (0% complete)
Jan 18 16:03:58.515: INFO: cluster upgrade is Progressing: Working towards 4.7.0-0.ci.test-2021-01-18-152608-ci-op-djqib51v: 70 of 662 done (10% complete)
Jan 18 16:04:08.517: INFO: cluster upgrade is Progressing: Working towards 4.7.0-0.ci.test-2021-01-18-152608-ci-op-djqib51v: 70 of 662 done (10% complete)
...
Jan 18 16:38:58.517: INFO: cluster upgrade is Progressing: Working towards 4.7.0-0.ci.test-2021-01-18-152608-ci-op-djqib51v: 554 of 662 done (83% complete), waiting on machine-config |
|
@jottofar: This pull request references Bugzilla bug 1768255, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
Make Done and Total available to syncStatus and calculate percent complete locally. Use math.Trunc to avoid rounding which occurs when only %.0f is used. This can also cause us to display 100% complete when Done != Total. Also dropped pkg/cvo/cvo_scenarios_test.go's use of diff.ObjectReflectDiff. Method was causing a panic and is also deprecated in favor of cmp.Diff. cmp.Diff does not print out difference so simply logged expected and actual values instead.
|
@jottofar: This pull request references Bugzilla bug 1768255, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
hold reason got fixed. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@jottofar: All pull requests linked via external trackers have merged: Bugzilla bug 1768255 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Make Done and Total available to syncStatus and calculate percent complete locally. Use
math.Truncto avoid rounding which occurs when only%.0fis used. This can also cause us to display 100% complete whenDone != Total.Also dropped pkg/cvo/cvo_scenarios_test.go's use of diff.ObjectReflectDiff. Method was causing a panic and is also deprecated in favor of cmp.Diff. cmp.Diff does not print out difference so simply logged expected and actual values instead.