Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1916384: pkg/cvo: Use shutdownContext for final status synchronization #501

Commits on Jan 20, 2021

  1. pkg/cvo: Use shutdownContext for final status synchronization

    Address a bug introduced by cc1921d (pkg/start: Release leader
    lease on graceful shutdown, 2020-08-03, openshift#424), where canceling the
    Operator.Run context would leave the operator with no time to attempt
    the final sync [1]:
    
      E0119 22:24:15.924216       1 cvo.go:344] unable to perform final sync: context canceled
    
    With this commit, I'm piping through shutdownContext, which gets a
    two-minute grace period beyond runContext, to give the operator time
    to push out that final status (which may include important information
    like the fact that the incoming release image has completed
    verification).
    
    [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1916384#c10
    wking committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    a0ce6f7 View commit details
    Browse the repository at this point in the history