Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1940652: Bump logging to --v=5 #533

Merged
merged 1 commit into from Apr 1, 2021
Merged

Bug 1940652: Bump logging to --v=5 #533

merged 1 commit into from Apr 1, 2021

Conversation

jottofar
Copy link
Contributor

To pick up all the .V(5) logging in pkg/cvo/sync_worker.go. I'm
especially interested in syncStatus logging that logs Generation
to help debug issue 1.

@wking @jottofar
Bump logging to --v=5
1ade6c9 
To pick up all the .V(5) logging in pkg/cvo/sync_worker.go.  I'm
especially interested in syncStatus logging that logs Generation
to help debug issue [1].

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1915559
@openshift-ci-robot
Copy link
Contributor

@jottofar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bump logging to --v=5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@jottofar
Copy link
Contributor Author

/retitle Bug 1915559: Bump logging to --v=5

@openshift-ci-robot openshift-ci-robot changed the title Bump logging to --v=5 Bug 1915559: Bump logging to --v=5 Mar 18, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 18, 2021
@openshift-ci-robot
Copy link
Contributor

@jottofar: This pull request references Bugzilla bug 1915559, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "4.6.z" instead
  • expected dependent Bugzilla bug 1909875 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1909875 to target a release in 4.6.0, 4.6.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1915559: Bump logging to --v=5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 18, 2021
@jottofar
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@jottofar: This pull request references Bugzilla bug 1915559, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "4.6.z" instead
  • expected dependent Bugzilla bug 1909875 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1909875 to target a release in 4.6.0, 4.6.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jottofar
Copy link
Contributor Author

/retitle Bug 1940652: Bump logging to --v=5

@openshift-ci-robot openshift-ci-robot changed the title Bug 1915559: Bump logging to --v=5 Bug 1940652: Bump logging to --v=5 Mar 18, 2021
@openshift-ci-robot
Copy link
Contributor

@jottofar: This pull request references Bugzilla bug 1940652, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1873900 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1873900 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

In response to this:

Bug 1940652: Bump logging to --v=5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 18, 2021
@wking
Copy link
Member

wking commented Mar 18, 2021

/lgtm
/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jwforres
Copy link
Member

This pull request was not picked by patch manager for the current z-stream window (%!s(float32=0.2)-4.5 z-stream is in maintenance - skipping medium severity bugs. Reach out to the patch manager if a policy override is needed.).

Score: %!f(MISSING)
Reason: %!s(MISSING)

NOTE: This message is automatically generated, if you have questions please ask on #forum-release

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 1, 2021
@markmc markmc mentioned this pull request Apr 1, 2021
Closed
@openshift-merge-robot openshift-merge-robot merged commit 7f24cf2 into openshift:release-4.5 Apr 1, 2021
@openshift-ci-robot
Copy link
Contributor

@jottofar: All pull requests linked via external trackers have merged:

Bugzilla bug 1940652 has been moved to the MODIFIED state.

In response to this:

Bug 1940652: Bump logging to --v=5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

@jianlinliu jianlinliu Awaiting requested review from jianlinliu

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jottofar @openshift-ci-robot @wking @openshift-bot @jwforres @markmc @openshift-merge-robot