Correctly initialize service host and port when environment is missing #590
Conversation
Signed-off-by: Arjun Naik <arjun.rn@gmail.com>
|
/lgtm looks pretty straightforward (great find), leaving this for Jack to verify this just to be sure /cc @jottofar |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
|
Haha, cut-and-paste strikes again. And then I guess the unit tests were made (or changed) such that they did not catch the issue. /unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arjunrn, jottofar, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
The init containers where not be correctly initialized with the service host and port. Also fixed tests.