Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the comparison between SyncWork references #592

Merged
merged 1 commit into from Jun 15, 2021

Conversation

arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Jun 10, 2021

Increase readability of comparison between *SyncWork references.

Signed-off-by: Arjun Naik <arjun.rn@gmail.com>
@jottofar
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arjunrn, jottofar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@arjunrn
Copy link
Contributor Author

arjunrn commented Jun 14, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Jun 15, 2021

pods should successfully create sandboxes by * are unrelated.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

In response to this:

pods should successfully create sandboxes by * are unrelated.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arjunrn
Copy link
Contributor Author

arjunrn commented Jun 15, 2021

/test unit

@wking
Copy link
Member

wking commented Jun 15, 2021

TestCVO_UpgradeVerifiedPayload race is unrelated.

/override ci/prow/unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/unit

In response to this:

[TestCVO_UpgradeVerifiedPayload race] is unrelated.

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking merged commit c7c7a4d into openshift:master Jun 15, 2021
@wking
Copy link
Member

wking commented Jun 15, 2021

All green, flake rate is high, so Prow's batch jobs are unlikely to pass. Merging by hand to clear out our PR backlog.

@arjunrn arjunrn deleted the simplify-sync-work-compare branch June 15, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants