Bug 1997596: install/0000_90_cluster-version-operator_02_servicemonitor: Trim labels for UpdateAvailable #643
Conversation
openshift-ci
bot
added
bugzilla/severity-low
|
@wking: This pull request references Bugzilla bug 1997596, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ls for UpdateAvailable
These are the only two labels we set on the metric, but the Prometheus
scraper adds some more, like job, namespace, pod, etc., to describe
who was scraping what. Reducing to the labels we care about avoids
annoying re-triggers, e.g. the CVO pod changes [1]. I'm using [2]:
sum by (channel,upstream) (cluster_version_available_updates)
to aggregate over all cluster_version_available_updates series by
collapsing the other labels and keeping only the listing two. For
example, an input series like:
cluster_version_available_updates{channel="stable-4.8", endpoint="metrics", instance="192.168.1.164:9099", job="cluster-version-operator", namespace="openshift-cluster-version", pod="cluster-version-operator-7dd68fd686-p7ckm", prometheus="openshift-monitoring/k8s", receive="true", service="cluster-version-operator", upstream="https://api.openshift.com/api/upgrades_info/v1/graph"} 3
will be collapsed to:
{channel="stable-4.8",upstream="https://api.openshift.com/api/upgrades_info/v1/graph"} 3
if there happened to be a second cluster_version_available_updates in
the cluster (which is unlikely, because the CVO only serves metrics
after acquiring the leader lock), that would get added in too. With
the label collapse, folks will be able to use a single silence per
channel/upstream tuple.
I could even see stripping all the labels, but folks who care enough
to bump their channel or upstream are presumably interested in hearing
about available updates, at least for a while, so having them
re-silence if they go back to not caring doesn't sound that tedious.
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1997596
[2]: https://prometheus.io/docs/prometheus/latest/querying/operators/#aggregation-operators
wking
force-pushed
the
UpdateAvailable-labels
branch
from
2f184b0
to
0721e7b
Compare
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@wking: This pull request references Bugzilla bug 1997596, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic, ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 1997596 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These are the only two labels we set on the metric, but the Prometheus scraper adds some more, like
job,namespace,pod, etc., to describe who was scraping what. Reducing to the labels we care about avoids annoying re-triggers, e.g. the CVO pod changes. With this change, folks will be able to use a single silence perchannel/upstreamtuple.I could even see stripping all the labels, but folks who care enough to bump their channel or upstream are presumably interested in hearing about available updates, at least for a while, so having them re-silence if they go back to not caring doesn't sound that tedious.