Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts #657

Merged
merged 1 commit into from Sep 16, 2021
Merged

Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts #657

merged 1 commit into from Sep 16, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #654

/assign wking

@wking
lib/resourcemerge/core: Remove unrecognized volumes and mounts
16f51af 
Since this package was created in d9f6718 (lib: add lib for
applying objects, 2018-08-14, openshift#7), the volume(mount) merge logic has
required manifest entries to exist, but has allowed in-cluster entries
to persist without removal.  That hasn't been a problem until [1]:

1. In 4.3, the autoscaler asked for a ca-cert volume mount, based on
   the cluster-autoscaler-operator-ca config map.
2. In 4.4, the autoscaler dropped those manifest entries [2].
3. In 4.9, the autoscaler asked the CVO to remove the config map [3].

That lead some born-in 4.3 clusters to have crashlooping autoscalers,
because the mount attempts kept failing on the missing config map.

We couldn't think of a plausible reason why cluster admins would want
to inject additional volume mounts in a CVO-managed pod configuration,
so this commit removes that ability and begins clearing away any
volume(mount) configuration that is not present in the reconciling
manifest.  Cluster administrators who do need to add additional mounts
in an emergency are free to use ClusterVersion's spec.overrides to
take control of a particular CVO-managed resource.

This joins a series of similar previous tightenings, including
02bb9ba (lib/resourcemerge/core: Clear env and envFrom if unset in
manifest, 2021-04-20, openshift#549) and ca299b8 (lib/resourcemerge: remove
ports which are no longer required, 2020-02-13, openshift#322).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=2002834
[2]: openshift/cluster-autoscaler-operator@f08589d#diff-547486373183980619528df695869ed32b80c18383bc16b57a5ee931bf0edd39L89
[3]: openshift/cluster-autoscaler-operator@9a7b3be#diff-d0cf785e044c611986a4d9bdd65bb373c86f9eb1c97bd3f105062184342a872dR4
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 16, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 2002834 with correct target release. Retitling PR to link to clone:
/retitle [release-4.9] Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts

In response to this:

[release-4.9] Bug 2002834: lib/resourcemerge/core: Remove unrecognized volumes and mounts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2002834: lib/resourcemerge/core: Remove unrecognized volumes and mounts [release-4.9] Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts Sep 16, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2004568, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2002834 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2002834 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

In response to this:

[release-4.9] Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 16, 2021
@wking
Copy link
Member

wking commented Sep 16, 2021

/retitle Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts

No need for the explicit [release-4.9]. GitHub tracks the target branch as structured metadata, and it is distracting noise in oc adm release info --changes-from ... output, like what the release-controller renders.

Also:

/lgtm

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts Sep 16, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Sep 16, 2021
@sdodson
Copy link
Member

sdodson commented Sep 16, 2021

Adding staff-eng-approved because this halted at least one OSD cluster upgrade to 4.9.

@sdodson
Copy link
Member

sdodson commented Sep 16, 2021

/test e2e-agnostic-upgrade

@wking
Copy link
Member

wking commented Sep 16, 2021

pods should successfully create sandboxes by not timing out is a persistent failure mode, but is unrelated to this PR.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

In response to this:

pods should successfully create sandboxes by not timing out is a persistent failure mode, but is unrelated to this PR.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 43d63b8 into openshift:release-4.9 Sep 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2004568 has been moved to the MODIFIED state.

In response to this:

Bug 2004568: lib/resourcemerge/core: Remove unrecognized volumes and mounts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianlinliu jianlinliu Awaiting requested review from jianlinliu

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@wking wking Awaiting requested review from wking

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @wking @openshift-bot @sdodson @openshift-merge-robot