New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/payload: Log load-time manifest exclusion at V(2) #749
pkg/payload: Log load-time manifest exclusion at V(2) #749
Conversation
We moved from --v=5 to --v=2 with c4a1004 (*: Use --v=2 logging to drop client-side throttling noise, 2022-01-04, openshift#721). But this V(5) logging slipped through via the parallel 5d343a5 (pkg/payload: Log manifest exclusion, 2021-12-10, openshift#712). Catch it up, to restore exclusion logging.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/749/pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade/1503776754840375296/artifacts/e2e-agnostic-upgrade/gather-extra/artifacts/pods/openshift-cluster-version_cluster-version-operator-5c6f9968d6-bbrd9_cluster-version-operator.log | grep excluding | head -n3
I0315 18:48:12.671744 1 payload.go:194] excluding 0000_30_cluster-api_00_credentials-request.yaml group=cloudcredential.openshift.io kind=CredentialsRequest namespace=openshift-cloud-credential-operator name=openshift-cluster-api-aws: tech-preview excluded, and release.openshift.io/feature-gate=TechPreviewNoUpgrade
I0315 18:48:12.671778 1 payload.go:194] excluding 0000_30_cluster-api_00_credentials-request.yaml group=cloudcredential.openshift.io kind=CredentialsRequest namespace=openshift-cloud-credential-operator name=openshift-cluster-api-azure: tech-preview excluded, and release.openshift.io/feature-gate=TechPreviewNoUpgrade
I0315 18:48:12.671791 1 payload.go:194] excluding 0000_30_cluster-api_00_credentials-request.yaml group=cloudcredential.openshift.io kind=CredentialsRequest namespace=openshift-cloud-credential-operator name=openshift-cluster-api-gcp: tech-preview excluded, and release.openshift.io/feature-gate=TechPreviewNoUpgrade /override ci/prow/e2e-agnostic |
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic, ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We moved from
--v=5
to--v=2
with c4a1004 (#721). But thisV(5)
logging slipped through via the parallel 5d343a5 (#712). Catch it up, to restore exclusion logging.