Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-230: lib/resourcebuilder/batch: Stop waiting on Job deadline exceeded #823

Merged
merged 1 commit into from Aug 18, 2022
Merged

OCPBUGS-230: lib/resourcebuilder/batch: Stop waiting on Job deadline exceeded #823

merged 1 commit into from Aug 18, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #764

/assign wking

@wking
lib/resourcebuilder/batch: Stop waiting on Job deadline exceeded
3c76980 
Avoid waiting for a job that that job controller has given up on [1].
With this change, when we have issues like DeadlineExceeded, we will
set 'err != nil' for "things are not good" and (new in this commit)
'done == true' for "waiting longer is useless".  Also split the 'err
!= nil' cases to "log the error and wait longer" and (new in this
commit) "bubble the error up to the caller" cases.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=2062568#c0
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 18, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2022

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2071211 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 401 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 2071211: lib/resourcebuilder/batch: Stop waiting on Job deadline exceeded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from vrutkovs and wking August 18, 2022 02:11
@wking wking changed the title [release-4.9] Bug 2071211: lib/resourcebuilder/batch: Stop waiting on Job deadline exceeded OCPBUGS-230: lib/resourcebuilder/batch: Stop waiting on Job deadline exceeded Aug 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2022 •
edited

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-230: lib/resourcebuilder/batch: Stop waiting on Job deadline exceeded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 18, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 18, 2022 •
edited by openshift-ci bot

@openshift-cherrypick-robot: This pull request references [Jira Issue OCPBUGS-230](https://issues.redhat.com//browse/OCPBUGS-230), which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.9.z) matches configured target version for branch (4.9.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST)
  • dependent bug Jira Issue OCPBUGS-229 is in the state Closed (Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Jira Issue OCPBUGS-229 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
  • bug has dependents

In response to this:

This is an automated cherry-pick of #764

/assign wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking
wking approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean pick.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@jiajliu
Copy link

jiajliu commented Aug 18, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 18, 2022
@LalatenduMohanty
Copy link
Member

/label backport-risk-assessed

@LalatenduMohanty
Copy link
Member

/test e2e-agnostic
/test e2e-agnostic-upgrade

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 18, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 76d16af and 8 for PR HEAD 3c76980 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 324c267 into openshift:release-4.9 Aug 18, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 18, 2022 •
edited by openshift-ci bot

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

[Jira Issue OCPBUGS-230](https://issues.redhat.com//browse/OCPBUGS-230) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #764

/assign wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-version-operator-container-v4.9.0-202311250023.p0.g324c267.assembly.stream for distgit cluster-version-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @jiajliu @LalatenduMohanty @openshift-bot @wking @openshift-merge-robot