syncStatus: Reduce verbosity when syncing nothing of interest #922
Conversation
openshift-ci
bot
added
the
approved
Status is synchronized every 15 seconds, and each call is currently logged with a lot of metadata, including full `status`. The metadata include words `error` and `Failure` which usually have zero values, but the words get noticed by filters and people eyeballing the logs. Because most of the time this event is not interesting, we can only log it if we happen to sync something interesting, like a failure, an only log every event on higher verbosity.
petr-muller
force-pushed
the
reduce-verbosity-on-business-as-usual
branch
from
aab0fb2
to
2fd54d1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-agnostic-ovn-upgrade-out-of-change looks like infra hiccup, who wrote that CI? |
|
So the failure makes me a little jumpy in context of #920 but we discussed that on Slack and apparently this is a different problem and the fix is the revert in openshift/operator-framework-olm#478 Also, I have verified via search.ci that our failure did not start with #920 but it started earlier. |
|
/test e2e-agnostic-ovn-upgrade-into-change |
|
/test e2e-agnostic-ovn-upgrade-into-change Installation failed, apiserver failed to go up |
|
/override ci/prow/e2e-agnostic-ovn-upgrade-into-change Nothing I have seen is related to a logging change ;) |
|
@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-ovn-upgrade-into-change In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Status is synchronized every 15 seconds, and each call is currently logged with a lot of metadata, including full
status. The metadata include wordserrorandFailurewhich usually have zero values, but the words get noticed by filters and people eyeballing the logs:Because most of the time this event is not interesting, we can only log it if we happen to sync something interesting, like a failure, an only log every event on higher verbosity.