Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-8079: install/0000_90_cluster-version-operator_02_servicemonitor: Drop $ from ${{ #992

Merged

Conversation

wking
Copy link
Member

@wking wking commented Oct 31, 2023

Fixing a ClusterOperatorDown typo from bbcc33d (#868) that I'd carried forward into ClusterReleaseNotAccepted in 734b9c5 (#906).

…om ${{

Fixing a ClusterOperatorDown typo from bbcc33d (pkg/cvo/metrics:
Add 'reason' to cluster_operator_up, 2022-11-21, openshift#868) that I'd
carried forward into ClusterReleaseNotAccepted in 734b9c5
(install/0000_90_cluster-version-operator_02_servicemonitor: Add
ClusterReleaseNotAccepted, 2023-02-23, openshift#906) [1].

[1]: https://issues.redhat.com/browse/OCPBUGS-8079
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 31, 2023
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-8079, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixing a ClusterOperatorDown typo from bbcc33d (#868) that I'd carried forward into ClusterReleaseNotAccepted in 734b9c5 (#906).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 00d0940 and 2 for PR HEAD 49bba21 in total

Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 52b7f32 into openshift:master Nov 1, 2023
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@wking: Jira Issue OCPBUGS-8079: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8079 has been moved to the MODIFIED state.

In response to this:

Fixing a ClusterOperatorDown typo from bbcc33d (#868) that I'd carried forward into ClusterReleaseNotAccepted in 734b9c5 (#906).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-11-01-080931

@wking wking deleted the remove-dollar-prefix-from-alert-reason branch November 1, 2023 15:10
@LalatenduMohanty
Copy link
Member

/cherrypick release-4.14

@openshift-cherrypick-robot

@LalatenduMohanty: new pull request created: #1040

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants