Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests: Be resilient to temporary unavailability of k8s #28

Merged
merged 2 commits into from
Nov 27, 2019

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 27, 2019

The tests are flaky due to leader re-elections in etcd. The following
error is logged every once in a while:

 single_scan_test.go:109: rpc error: code = Unavailable desc = etcdserver: leader changed

So lets try to be more resilient in our tests.

The tests are flaky due to leader re-elections in etcd. The following
error is logged every once in a while:

     single_scan_test.go:109: rpc error: code = Unavailable desc = etcdserver: leader changed

So lets try to be more resilient in our tests.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
A timeout might happen cause the cluster might be too busy. So we also
need to be resilient to timeouts.
@JAORMX
Copy link
Contributor Author

JAORMX commented Nov 27, 2019

/test e2e-aws

etcd failed again... but this time it was on the cleanup which is in the operator-sdk code.

@JAORMX
Copy link
Contributor Author

JAORMX commented Nov 27, 2019

pushed operator-framework/operator-sdk#2277 to avoid issues like this in the future.

@jhrozek
Copy link
Contributor

jhrozek commented Nov 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, jhrozek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JAORMX JAORMX merged commit 596cfc9 into openshift:master Nov 27, 2019
@openshift-ci-robot
Copy link

@JAORMX: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 876a86c link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JAORMX JAORMX deleted the unavailable branch December 11, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants