Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Surface a new attribute instructions that contains OCIL #567

Merged
merged 1 commit into from Feb 12, 2021

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Feb 11, 2021

Extends the ComplianceCheckResult API object with a new attribute
instructions that contains the OCIL attribute from OpenScap rule.

This attribute contains the manual checks for cases when a rule cannot
be evaluated with a OVAL check.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2021
@JAORMX
Copy link
Contributor

JAORMX commented Feb 11, 2021

/retest

@@ -35,6 +35,9 @@ spec:
id:
description: A unique identifier of a check
type: string
instructions:
description: Manual check steps in case the rule can't be evaluated automatically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this only show if there rule can't be evaluated automatically?

@jhrozek
Copy link
Contributor Author

jhrozek commented Feb 11, 2021 via email

@JAORMX
Copy link
Contributor

JAORMX commented Feb 11, 2021

On Thu, Feb 11, 2021 at 09:47:04AM -0800, Juan Osorio Robles wrote:

@JAORMX commented on this pull request.

@@ -35,6 +35,9 @@ spec:
id:
description: A unique identifier of a check
type: string

  •      instructions:
    
  •        description: Manual check steps in case the rule can't be evaluated automatically
    

Does this only show if there rule can't be evaluated automatically?

No, always.

Let's change the description. With the current way it's written out sounds like that key will only have text if automatic remediation wasn't possible

Extends the ComplianceCheckResult API object with a new attribute
instructions that contains the OCIL attribute from OpenScap rule.

This attribute contains the manual checks for cases when a rule cannot
be evaluated with a OVAL check.

Jira: CMP-767
@JAORMX
Copy link
Contributor

JAORMX commented Feb 12, 2021

/retest

@JAORMX
Copy link
Contributor

JAORMX commented Feb 12, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, jhrozek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1894161 into openshift:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants