New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Surface a new attribute instructions that contains OCIL #567
Conversation
/retest |
@@ -35,6 +35,9 @@ spec: | |||
id: | |||
description: A unique identifier of a check | |||
type: string | |||
instructions: | |||
description: Manual check steps in case the rule can't be evaluated automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this only show if there rule can't be evaluated automatically?
On Thu, Feb 11, 2021 at 09:47:04AM -0800, Juan Osorio Robles wrote:
@JAORMX commented on this pull request.
> @@ -35,6 +35,9 @@ spec:
id:
description: A unique identifier of a check
type: string
+ instructions:
+ description: Manual check steps in case the rule can't be evaluated automatically
Does this only show if there rule can't be evaluated automatically?
No, always.
|
Let's change the description. With the current way it's written out sounds like that key will only have text if automatic remediation wasn't possible |
Extends the ComplianceCheckResult API object with a new attribute instructions that contains the OCIL attribute from OpenScap rule. This attribute contains the manual checks for cases when a rule cannot be evaluated with a OVAL check. Jira: CMP-767
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, jhrozek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Extends the ComplianceCheckResult API object with a new attribute
instructions that contains the OCIL attribute from OpenScap rule.
This attribute contains the manual checks for cases when a rule cannot
be evaluated with a OVAL check.